From: Mariusz Gorski <marius.gorski@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Willy Tarreau <willy@meta-x.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: panel: Fix single-open policy race condition
Date: Wed, 5 Nov 2014 12:51:22 +0100 [thread overview]
Message-ID: <20141105115121.GA2592@firebird> (raw)
In-Reply-To: <20141105101910.GO6879@mwanda>
On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote:
> On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote:
> > Fix the implementation of a single-open policy for both
> > devices (lcd and keypad) by using atomic_t instead of plain ints.
> >
>
> This seems like it might be a real life bug that you have experienced?
No, I don't think it might really happen in real life. I found it just
by reading the code. A similar solution is used in Chapter 6 of the LDD3
book, so I thought it might be a good idea to fix is here.
> The changelog should tell the user visible effects of the bug. If you
> have some dmesg output that would be helpful as well.
Nope, I can't really reproduce it ATM.
> regards,
> dan carpenter
>
Cheers,
Mariusz
next prev parent reply other threads:[~2014-11-05 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 21:47 [PATCH] staging: panel: Fix single-open policy race condition Mariusz Gorski
2014-11-05 10:19 ` Dan Carpenter
2014-11-05 11:51 ` Mariusz Gorski [this message]
2014-11-11 7:37 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105115121.GA2592@firebird \
--to=marius.gorski@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.