From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 0/7] drm: Sanitize DRM_IOCTL_MODE_CREATE_DUMB input Date: Wed, 5 Nov 2014 15:45:17 +0100 Message-ID: <20141105144516.GB24353@ulmo> References: <1415193919-1687-1-git-send-email-thierry.reding@gmail.com> <20141105142442.GL4042@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1255033257==" Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 3395D6E935 for ; Wed, 5 Nov 2014 06:45:20 -0800 (PST) Received: by mail-wi0-f176.google.com with SMTP id h11so12611630wiw.9 for ; Wed, 05 Nov 2014 06:45:19 -0800 (PST) In-Reply-To: <20141105142442.GL4042@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: Benjamin Gaignard , Daniel Vetter , dri-devel@lists.freedesktop.org, Tomi Valkeinen , Archit Taneja , Laurent Pinchart , Dave Airlie List-Id: dri-devel@lists.freedesktop.org --===============1255033257== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8GpibOaaTibBMecb" Content-Disposition: inline --8GpibOaaTibBMecb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 05, 2014 at 02:24:42PM +0000, Russell King - ARM Linux wrote: > On Wed, Nov 05, 2014 at 02:25:12PM +0100, Thierry Reding wrote: > > Discussion on IRC lead to the conclusion that new IOCTLs should have > > input validation and require userspace to zero out output parameters to > > avoid this kind of mess in the future. In order to help avoid this kind > > of ambiguity it would be a good idea to start documenting IOCTLs more > > officially (e.g. in the DRM DocBook). >=20 > That is a good point, however not everyone can build the documentation. > I tried a while back and the whole documentation subsystem is /soo/ > fragile its untrue. You have to have the exact right versions installed > and hope that the exact right versions have configured themselves to > work together correctly, otherwise you get cryptic unsolvable error > messages. Tex is notorious for these problems. I usually only build the HTML documentation which tends to be less prone to the issues that you're describing. > When I tried to generate the docbook stuff, after spending a significant > amount of time trying to debug it, I just gave up completely with any > ideas about ever adding to the documentation. I've since decided that > I am /never/ going to do anything past adding docbook comments to files. >=20 > If someone cares about linking them into the rest of the docbook system, > and they have the capability to generate the docbook output, then that's > fine and dandy, but I believe that requiring everyone to have that > capability is asking far too much. It looks as if perhaps running the xmldocs target would at least run kerneldoc on the files even if it doesn't produce anything very human readable. If that works for you it'd at least give you a means to check that the kerneldoc comments you've added are consistent. Thierry --8GpibOaaTibBMecb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUWjf8AAoJEN0jrNd/PrOhbYMQAIj58TjztNpRQJU8R5u9HgJD 3j6ajUg/VcFTdvGkmnlIBu2oKodcCt+K+cKO/SjPRAaSlNU6y8H/Jvb7hY1m1PCH 4ufArCct4wLSkdE6lL8EbQtqWUAX91dbv1syf+tCnk7FMqxZUb+E9xQnZ3d7FbIh rrw8NRXAhRy8X2IQo58IR0HekVKGDL4r5yU8Icy/U3Z9ZTQG2zVaqsH4KIPWr7fE QTCfhQXMsCDi/mB1QyBVNO/ndFW80ISXpu8MlF6iZ1X2roVIfuZ9biK78Rg2JhHY 6kbmi0eNveC4Us3xIMPvvMt2/IV+byCZ8Kfe+jLqKzdYG/VthDSVVXn0LY7w3I9H lS4WFmtRlyO4c4hd2zAD3weYCBaEmDkDTeMUjQHs+03A3uzi09cWZf5PY+grB8EN DWK8bbgKFN4iRZIpOnCK4hVaiSkCr05RsITBQzRui10/ABNXjuigwS+yqQd+fTqe JxpzOajF1lzCkGPhWge1WbGuPH+18CIo0CAfM7pTmK0pMj7QgylO6akrM25OI6A1 PYh9y+Y/80srRaeqJKCBVNwMMnZQSYBdZrY1G64u3w1tciq28njDhcamnp+mTlbU exlzR6D6Hr6BOgzXO1taYgfVQTEaeonA3GN4V62aWsFio47f3B9cmb658LPzuFdL BpQiwJ5ZvtOiXHwMF4MY =Yp7P -----END PGP SIGNATURE----- --8GpibOaaTibBMecb-- --===============1255033257== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1255033257==--