All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: bstroesser@ts.fujitsu.com
Cc: neilb@suse.de, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils] [PATCH 0/3] rpc.mountd: fix some vulnerabilities
Date: Wed, 5 Nov 2014 16:05:46 -0500	[thread overview]
Message-ID: <20141105210546.GH6513@fieldses.org> (raw)
In-Reply-To: <61eb00$5dituo@dgate20u.abg.fsc.net>

On Wed, Nov 05, 2014 at 09:21:37PM +0100, bstroesser@ts.fujitsu.com wrote:
> Hello,
> 
> I'm sending a small set of 3 patches for a problem, that I have
> reported a few weeks ago.
> rpc.mountd can be blocked by a bad client, that sends lots of
> RPC requests, but never reads the replies from the socket either
> intentionally or e.g. caused by a wrong configured MTU.
> 
> While looking for a possible solution, I found another weakness
> in rpc.mountd if it is used "multithreaded" (-t nn).
> 
> The first two patches fix that weakness in the case of !HAVE_LIBTIRPC
> and HAVE_LIBTIRPC.

They look fine to me.

> The third patch more a kind of suggestion how the main problem could
> be fixed.

Sounds reasonable to me.

> I don't know whether we can set MAXREC without causing
> new troubles. When this patch is used, a  further patch for libtirpc
> also should be used. You can find it here:
>     http://sourceforge.net/p/libtirpc/mailman/libtirpc-devel/?viewmonth=201409

So applying this last patch and then building against an unpatched
libtirpc would expose us to a serious bug?  Do we need to do something
to make that less likely to happen?

--b.

> 
> Best regards,
> Bodo

       reply	other threads:[~2014-11-05 21:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <61eb00$5dituo@dgate20u.abg.fsc.net>
2014-11-05 21:05 ` J. Bruce Fields [this message]
2014-11-05 21:25   ` [nfs-utils] [PATCH 0/3] rpc.mountd: fix some vulnerabilities Strösser, Bodo
     [not found]     ` <20141106084741.40980d12@notabene.brown>
2014-11-05 21:55       ` J. Bruce Fields
2014-11-06 15:00       ` Steve Dickson
2014-11-05 20:21 bstroesser
2014-11-11 18:24 ` Steve Dickson
2014-11-11 19:01   ` Strösser, Bodo
2014-11-11 23:00   ` NeilBrown
2014-11-12 15:58     ` Steve Dickson
2014-11-12 18:57 ` Steve Dickson
2014-11-12 19:26   ` Strösser, Bodo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105210546.GH6513@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=bstroesser@ts.fujitsu.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.