From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 07/11] omap: hsmmc: assume cd gpio is active low
Date: Wed, 5 Nov 2014 16:31:04 -0500 [thread overview]
Message-ID: <20141105213104.GA15133@bill-the-cat> (raw)
In-Reply-To: <1415007147-12562-8-git-send-email-grinberg@compulab.co.il>
On Mon, Nov 03, 2014 at 11:32:23AM +0200, Igor Grinberg wrote:
> Switch the default CD GPIO polarity to active low.
>
> The current hsmmc driver assumption that the CD GPIO is active high, but
> in the real hardware, usually the opposite holds.
> The usual SD card socket has a mechanical switch which is grounded as
> soon as a card is inserted.
> Of course there might be some board logic which inverts the signal, but
> as far as current users are concerned, there is no such logic.
>
> Current U-Boot users either not using the CD functionality, or have a
> different way (e.g. external to SoC GPIO controller) for checking the
> card presence.
>
> This patch also brings the polarity assumption in line with the Linux
> kernel and adds appropriate comments.
>
> This patch also might spare issues once the TWL GPIO driver will be
> converted to the DM.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> Cc: Dmitry Lifshitz <lifshitz@compulab.co.il>
> Reviewed-by: Tom Rini <trini@ti.com>
Applied to u-boot-ti/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141105/eb3c0d24/attachment.pgp>
next prev parent reply other threads:[~2014-11-05 21:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 9:32 [U-Boot] [PATCH 00/11] Add support for CompuLab cm-t3517 SoM Igor Grinberg
2014-11-03 9:32 ` [U-Boot] [PATCH 01/11] am335x: make get_board_rev() function weak Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 11:29 ` [U-Boot] [PATCH v2] " Igor Grinberg
2014-11-05 21:33 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 02/11] compulab: refactor board revision handling Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:30 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 03/11] omap3: cm-t35: move the USB hub reset code Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:30 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 04/11] omap3: cm-t35: extract the splash code from board Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:30 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 05/11] omap3: cm-t35: move the SMC911x code Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:30 ` [U-Boot] [U-Boot,05/11] " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 06/11] omap3: cm-t35: move get_board_serial() fallback Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:30 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 07/11] omap: hsmmc: assume cd gpio is active low Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:31 ` Tom Rini [this message]
2014-11-03 9:32 ` [U-Boot] [PATCH 08/11] omap3: cm-t3517: add basic board support Igor Grinberg
2014-11-04 16:46 ` Tom Rini
2014-11-05 12:16 ` Igor Grinberg
2014-11-05 12:23 ` Tom Rini
2014-11-05 12:53 ` Igor Grinberg
2014-11-05 12:25 ` [U-Boot] [PATCH v2 8/11] " Igor Grinberg
2014-11-05 21:33 ` [U-Boot] [U-Boot, v2, " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 09/11] omap3: cm-t3517: add USB support Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:31 ` [U-Boot] [U-Boot,09/11] " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 10/11] omap3: cm-t3517: add Ethernet support Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:31 ` [U-Boot] [U-Boot,10/11] " Tom Rini
2014-11-03 9:32 ` [U-Boot] [PATCH 11/11] omap3: cm-t3517: add LCD/DVI and splash support Igor Grinberg
2014-11-04 16:45 ` Tom Rini
2014-11-05 21:31 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105213104.GA15133@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.