Re: [PATCH 10/10] scsi: Move remaining printk() statement to scmd_printk()

[Christoph Hellwig <hch@infradead.org>]

On Tue, Nov 04, 2014 at 09:06:49AM +0100, Hannes Reinecke wrote:
> One statement was missing from the conversion to dev_printk().
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/scsi/scsi.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
> index 92d5912..9880b59 100644
> --- a/drivers/scsi/scsi.c
> +++ b/drivers/scsi/scsi.c
> @@ -541,10 +541,12 @@ void scsi_log_send(struct scsi_cmnd *cmd)
>  				    "Send: scmd 0x%p\n", cmd);
>  			scsi_print_command(cmd);
>  			if (level > 3) {
> -				printk(KERN_INFO "buffer = 0x%p, bufflen = %d,"
> -				       " queuecommand 0x%p\n",
> -					scsi_sglist(cmd), scsi_bufflen(cmd),
> -					cmd->device->host->hostt->queuecommand);
> +				struct Scsi_Host *shost = cmd->device->host;
> +				scmd_printk(KERN_INFO, cmd,
> +					    "buffer = 0x%p, bufflen = %d,"
> +					    " queuecommand 0x%p\n",
> +					    scsi_sglist(cmd), scsi_bufflen(cmd),
> +					    shost->hostt->queuecommand);

This printk doesn't look very useful, I'd rather kill it.