From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors Date: Thu, 6 Nov 2014 12:58:55 +0200 Message-ID: <20141106105855.GL1618@lahna.fi.intel.com> References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> <545843B1.3020101@nvidia.com> <2455157.3p7mHhT8im@vostro.rjw.lan> <20141106103033.GK1618@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:46565 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbaKFK7D (ORCPT ); Thu, 6 Nov 2014 05:59:03 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Alexandre Courbot , Linus Walleij , Bryan Wu , Richard Purdie , Ben Dooks , Kukjin Kim , Jason Cooper , Andrew Lunn , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , Linux-sh list On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: > Hi Mika, > > On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg > wrote: > >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on > >> non-DT platforms for me: > >> > >> gpiod_direction_output: invalid GPIO > >> leds-gpio: probe of leds-gpio failed with error -22 > >> > >> (desc is NULL in gpiod_direction_output()). > >> > >> DT shmobile reference/multi-platform are fine. > >> > >> I noticed the hard way, as I wanted to add some LEDs to a new platform, > >> but couldn't get it work. It turned out it also had stopped working on > >> r8a7740/armadillo-legacy, so I started bisecting... > > > > Which board file that is? > > > > There is a bug that gpio_to_desc() returns NULL instead if ERR_PTR() in > > that patch but I wonder why gpio_is_valid() and devm_gpio_request_one() > > do not complain about that prior. > > arch/arm/mach-shmobile/board-armadillo800eva.c Thanks. Are you able to put some printks() to the 'if (!template->gpiod)' branch so that it prints out gpio number and what does devm_gpio_request_one() return? Something like: if (!template->gpiod) { ... ret = devm_gpio_request_one(parent, template->gpio, flags, template->name); dev_info(parent, "GPIO %u, ret: %d\n", template->gpio, ret); if (ret < 0) ... led_dat->gpiod = gpio_to_desc(template->gpio); dev_info(parent, "GPIOD: %p\n", led_dat->gpiod); } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Date: Thu, 06 Nov 2014 10:58:55 +0000 Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors Message-Id: <20141106105855.GL1618@lahna.fi.intel.com> List-Id: References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> <545843B1.3020101@nvidia.com> <2455157.3p7mHhT8im@vostro.rjw.lan> <20141106103033.GK1618@lahna.fi.intel.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Alexandre Courbot , Linus Walleij , Bryan Wu , Richard Purdie , Ben Dooks , Kukjin Kim , Jason Cooper , Andrew Lunn , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , Linux-sh list On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: > Hi Mika, > > On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg > wrote: > >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on > >> non-DT platforms for me: > >> > >> gpiod_direction_output: invalid GPIO > >> leds-gpio: probe of leds-gpio failed with error -22 > >> > >> (desc is NULL in gpiod_direction_output()). > >> > >> DT shmobile reference/multi-platform are fine. > >> > >> I noticed the hard way, as I wanted to add some LEDs to a new platform, > >> but couldn't get it work. It turned out it also had stopped working on > >> r8a7740/armadillo-legacy, so I started bisecting... > > > > Which board file that is? > > > > There is a bug that gpio_to_desc() returns NULL instead if ERR_PTR() in > > that patch but I wonder why gpio_is_valid() and devm_gpio_request_one() > > do not complain about that prior. > > arch/arm/mach-shmobile/board-armadillo800eva.c Thanks. Are you able to put some printks() to the 'if (!template->gpiod)' branch so that it prints out gpio number and what does devm_gpio_request_one() return? Something like: if (!template->gpiod) { ... ret = devm_gpio_request_one(parent, template->gpio, flags, template->name); dev_info(parent, "GPIO %u, ret: %d\n", template->gpio, ret); if (ret < 0) ... led_dat->gpiod = gpio_to_desc(template->gpio); dev_info(parent, "GPIOD: %p\n", led_dat->gpiod); } From mboxrd@z Thu Jan 1 00:00:00 1970 From: mika.westerberg@linux.intel.com (Mika Westerberg) Date: Thu, 6 Nov 2014 12:58:55 +0200 Subject: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors In-Reply-To: References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> <545843B1.3020101@nvidia.com> <2455157.3p7mHhT8im@vostro.rjw.lan> <20141106103033.GK1618@lahna.fi.intel.com> Message-ID: <20141106105855.GL1618@lahna.fi.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: > Hi Mika, > > On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg > wrote: > >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on > >> non-DT platforms for me: > >> > >> gpiod_direction_output: invalid GPIO > >> leds-gpio: probe of leds-gpio failed with error -22 > >> > >> (desc is NULL in gpiod_direction_output()). > >> > >> DT shmobile reference/multi-platform are fine. > >> > >> I noticed the hard way, as I wanted to add some LEDs to a new platform, > >> but couldn't get it work. It turned out it also had stopped working on > >> r8a7740/armadillo-legacy, so I started bisecting... > > > > Which board file that is? > > > > There is a bug that gpio_to_desc() returns NULL instead if ERR_PTR() in > > that patch but I wonder why gpio_is_valid() and devm_gpio_request_one() > > do not complain about that prior. > > arch/arm/mach-shmobile/board-armadillo800eva.c Thanks. Are you able to put some printks() to the 'if (!template->gpiod)' branch so that it prints out gpio number and what does devm_gpio_request_one() return? Something like: if (!template->gpiod) { ... ret = devm_gpio_request_one(parent, template->gpio, flags, template->name); dev_info(parent, "GPIO %u, ret: %d\n", template->gpio, ret); if (ret < 0) ... led_dat->gpiod = gpio_to_desc(template->gpio); dev_info(parent, "GPIOD: %p\n", led_dat->gpiod); }