From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
subhransu.s.prusty@intel.com, lgirdwood@gmail.com
Subject: Re: [PATCH v3 6/6] ASoC: Intel: Add Merrifield machine driver
Date: Thu, 6 Nov 2014 18:48:35 +0530 [thread overview]
Message-ID: <20141106131835.GE1870@intel.com> (raw)
In-Reply-To: <20141106125119.GD8509@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 606 bytes --]
On Thu, Nov 06, 2014 at 12:51:19PM +0000, Mark Brown wrote:
> On Tue, Nov 04, 2014 at 04:25:20PM +0530, Vinod Koul wrote:
>
> > +static int mrfld_wm8958_set_clk(struct snd_soc_dai *codec_dai)
> > +{
> > + int ret = 0;
> > + struct snd_soc_card *card = codec_dai->card;
> > +
> > + ret = snd_soc_dai_set_tdm_slot(codec_dai, 0xf0, 0xf0, 4, 24);
> > + if (ret < 0) {
> > + dev_err(card->dev, "can't set codec pcm format %d\n", ret);
> > + return ret;
> > + }
>
> We already set this on init - why do we need to set it each time here
> too?
It is not required, will remove.
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-11-06 13:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 10:55 [PATCH v3 0/6] ASoC: Intel: ACPI support and machines Vinod Koul
2014-11-04 10:55 ` [PATCH v3 1/6] ASoC: Intel: mrfld - remove unnecessary check for pointer Vinod Koul
2014-11-06 12:36 ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 2/6] ASoC: Intel: mrfld - create separate module for pci part Vinod Koul
2014-11-06 12:36 ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 3/6] ASoC: Intel: mrfld - add shim save restore Vinod Koul
2014-11-06 12:36 ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 4/6] ASoC: Intel: mrfld- add ACPI module Vinod Koul
2014-11-06 12:43 ` Mark Brown
2014-11-06 13:09 ` Vinod Koul
2014-11-06 13:44 ` Mark Brown
2014-11-10 6:18 ` Vinod Koul
2014-11-04 10:55 ` [PATCH v3 5/6] ASoC: Intel: add BYTCR machine driver with RT5640 Vinod Koul
2014-11-06 12:48 ` Mark Brown
2014-11-06 13:11 ` Vinod Koul
2014-11-06 13:46 ` Mark Brown
2014-11-10 6:20 ` Vinod Koul
2014-11-10 10:03 ` Mark Brown
2014-11-04 10:55 ` [PATCH v3 6/6] ASoC: Intel: Add Merrifield machine driver Vinod Koul
2014-11-06 12:51 ` Mark Brown
2014-11-06 13:18 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106131835.GE1870@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.