From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Robert Elliott <elliott@hp.com>, Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@fb.com>,
Kashyap Desai <kashyap.desai@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Mike Christie <michaelc@cs.wisc.edu>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH 08/11] scsi: always assign block layer tags if enabled
Date: Thu, 6 Nov 2014 17:31:44 +0100 [thread overview]
Message-ID: <20141106163144.GA23914@lst.de> (raw)
In-Reply-To: <545BA1B0.8030604@acm.org>
On Thu, Nov 06, 2014 at 05:28:32PM +0100, Bart Van Assche wrote:
> Apparently this patch removes the
> queue_flag_set_unlocked(QUEUE_FLAG_QUEUED, sdev->request_queue) call for
> the multiqueue case. I think it should be explained in the commit message
> why that has been done.
Ok, I will update it.
>> -static inline void scsi_deactivate_tcq(struct scsi_device *sdev, int depth)
>> -{
>> - if (blk_queue_tagged(sdev->request_queue))
>> - blk_queue_free_tags(sdev->request_queue);
>> - scsi_adjust_queue_depth(sdev, 0, depth);
>> -}
>
> Hmm ... where has the blk_queue_free_tags() call been moved to ?
It's gone. Despite the confusing name blk_queue_free_tags just clears
QUEUE_FLAG_QUEUED, which we now never do until the actual tag structure
is freed when the queue is torn via blk_release_queue ->
__blk_queue_free_tags.
next prev parent reply other threads:[~2014-11-06 16:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 7:54 tag handling refactor Christoph Hellwig
2014-11-04 7:54 ` [PATCH 01/11] scsi: provide a generic change_queue_type method Christoph Hellwig
2014-11-04 8:26 ` Hannes Reinecke
2014-11-05 2:09 ` Martin K. Petersen
2014-11-06 15:28 ` Bart Van Assche
2014-11-06 15:35 ` Christoph Hellwig
2014-11-04 7:54 ` [PATCH 02/11] scsi: add new scsi-command flag for tagged commands Christoph Hellwig
2014-11-04 8:38 ` Hannes Reinecke
2014-11-04 10:35 ` Christoph Hellwig
2014-11-04 10:44 ` Hannes Reinecke
2014-11-05 2:12 ` Martin K. Petersen
2014-11-04 7:54 ` [PATCH 03/11] scsi: remove ordered_tags scsi_device field Christoph Hellwig
2014-11-05 2:14 ` Martin K. Petersen
2014-11-06 15:44 ` Bart Van Assche
2014-11-04 7:54 ` [PATCH 04/11] scsi: remove ordered_tag host template field Christoph Hellwig
2014-11-04 8:38 ` Hannes Reinecke
2014-11-05 2:15 ` Martin K. Petersen
2014-11-06 15:45 ` Bart Van Assche
2014-11-04 7:54 ` [PATCH 05/11] scsi: remove abuses of scsi_populate_tag Christoph Hellwig
2014-11-04 8:45 ` Hannes Reinecke
2014-11-04 10:37 ` Christoph Hellwig
2014-11-04 7:54 ` [PATCH 06/11] mptfusion: don't change queue type in ->change_queue_depth Christoph Hellwig
2014-11-04 8:46 ` Hannes Reinecke
2014-11-05 2:17 ` Martin K. Petersen
2014-11-04 7:54 ` [PATCH 07/11] scsi: remove use_blk_tcq Scsi_Host field Christoph Hellwig
2014-11-04 8:46 ` Hannes Reinecke
2014-11-05 2:18 ` Martin K. Petersen
2014-11-04 7:54 ` [PATCH 08/11] scsi: always assign block layer tags if enabled Christoph Hellwig
2014-11-04 9:01 ` Hannes Reinecke
2014-11-04 10:42 ` Christoph Hellwig
2014-11-04 10:46 ` Hannes Reinecke
2014-11-05 2:32 ` Martin K. Petersen
2014-11-05 2:34 ` Martin K. Petersen
2014-11-06 16:28 ` Bart Van Assche
2014-11-06 16:31 ` Christoph Hellwig [this message]
2014-11-04 7:54 ` [PATCH 09/11] scsi: don't set tagging state from scsi_adjust_queue_depth Christoph Hellwig
2014-11-04 9:26 ` Hannes Reinecke
2014-11-04 10:47 ` Christoph Hellwig
2014-11-05 2:50 ` Martin K. Petersen
2014-11-04 7:54 ` [PATCH 10/11] scsi: don't force tagged_supported in drivers Christoph Hellwig
2014-11-04 8:16 ` Jack Wang
2014-11-04 10:34 ` Christoph Hellwig
2014-11-04 7:54 ` [PATCH 11/11] ufs: remove spurious scsi_set_tag_type call Christoph Hellwig
2014-11-05 19:26 ` tag handling refactor Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-11-10 15:56 tag handling refactor V2 Christoph Hellwig
2014-11-10 15:56 ` [PATCH 08/11] scsi: always assign block layer tags if enabled Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106163144.GA23914@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=bvanassche@acm.org \
--cc=elliott@hp.com \
--cc=g.liakhovetski@gmx.de \
--cc=hare@suse.de \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=sreekanth.reddy@avagotech.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.