From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
jslaby@suse.cz, devicetree@vger.kernel.org,
jingchang.lu@freescale.com, gregory.0xf0@gmail.com
Subject: Re: [PATCH] serial: of-serial: zero-out struct of_serial_info
Date: Thu, 6 Nov 2014 10:33:34 -0800 [thread overview]
Message-ID: <20141106183334.GB24232@kroah.com> (raw)
In-Reply-To: <545919B5.9020905@gmail.com>
On Tue, Nov 04, 2014 at 10:23:49AM -0800, Florian Fainelli wrote:
> On 10/30/2014 02:55 PM, Arnd Bergmann wrote:
> > On Thursday 30 October 2014 14:18:33 Florian Fainelli wrote:
> >> of_platform_serial_probe() invokes of_platform_serial_setup() with a
> >> kmalloc'd struct of_serial_info cookie, which is not much of a problem
> >> for most of the struct of_serial_info fields we access but info->clk.
> >>
> >> On platforms which do not provide a clock phandle for their UART nodes
> >> but do provide a 'clock-frequency' property, we basically leave the
> >> info->clk variable uninitialized, and this craps out during
> >> suspend/resume with oopses, crashes or warnings in the clock code.
> >>
> >> Fix this by using kzalloc() which also zeroes-out the structure and
> >> provides an initialized info->clk member set to NULL.
> >>
> >> Fixes: 2dea53bf57783 ("serial: of-serial: add PM suspend/resume support")
> >> Fixes: e34b9c94b6e8d ("[POWERPC] of_serial: add port type checking")
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >>
> >
> > I thought I'd acked this patch before, maybe someone else sent the same
> > one. This is definitely required, so
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
>
> Thanks, so who's taking that patch? Let me know if I need to resubmit
> targeting a specific tree.
Someone else sent this before you did, and I took that version instead,
sorry.
greg k-h
next prev parent reply other threads:[~2014-11-06 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 21:18 [PATCH] serial: of-serial: zero-out struct of_serial_info Florian Fainelli
2014-10-30 21:55 ` Arnd Bergmann
2014-11-04 18:23 ` Florian Fainelli
2014-11-06 18:33 ` Greg KH [this message]
2014-11-06 18:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106183334.GB24232@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=jingchang.lu@freescale.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.