From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: davem@davemloft.net, sowmini.varadhan@oracle.com,
david.stevens@oracle.com, ben@decadent.org.uk
Cc: netdev@vger.kernel.org
Subject: [PATCH 0/2 net-next] sunvnet: bug fixes
Date: Thu, 6 Nov 2014 14:50:54 -0500 [thread overview]
Message-ID: <20141106195054.GD6238@oracle.com> (raw)
This patch series has a coding-style fix and a bug fix.
The coding style fix (patch 1) is the extra indentation flagged by
Ben Hutchings:
http://marc.info/?l=linux-netdev&m=141529243409594&w=2
The bugfix (patch 2) is the following:
when vnet_event_napi() is called as part of napi_resume
(i.e., continuation of a previous NAPI read that was truncated
due to budget constraints), and then finds no more packets to read,
the code was trying to avoid an additional trip through ldc_rx
as an optimization. However, when this corner case happens, we would
need to reset a number of dring state bits such as rcv_nxt carefully,
which quickly becomes complex and hacky. The cleaner solution
is to just roll back to vnet_poll, re-enable interrupts and set up
dring state as was done in the pre-NAPI version of the driver.
Sowmini Varadhan (2):
Fix indentation in maybe_tx_wakeup()
Return from vnet_napi_event() if no packets to read
drivers/net/ethernet/sun/sunvnet.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--
1.8.4.2
next reply other threads:[~2014-11-06 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 19:50 Sowmini Varadhan [this message]
2014-11-06 20:17 ` [PATCH 0/2 net-next] sunvnet: bug fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106195054.GD6238@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.