From: wenxiong@linux.vnet.ibm.com
To: James.Bottomley@HansenPartnership.com
Cc: hch@infradead.org, linux-scsi@vger.kernel.org, brking@linux.vnet.ibm.com
Subject: [ V3 PATCH 2/2] scsi: TUR path is down after adapter gets reset with multipath
Date: Thu, 06 Nov 2014 15:11:23 -0600 [thread overview]
Message-ID: <20141106211336.369139152@linux.vnet.ibm.com> (raw)
In-Reply-To: 20141106211121.526781033@linux.vnet.ibm.com
[-- Attachment #1: allow_restart2 --]
[-- Type: text/plain, Size: 1327 bytes --]
This patch fixes an issue with multipath ipr SAS devices which require a
start unit command to be issued following an adapter reset. Without this
patch, paths get marked failed following an adapter reset and since the
error handler never gets invoked to issue the start unit, the paths are
never recovered. Returning FAILED for this case ensures the error
handler wakes up to issue the start unit.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Teste-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 7 +++++++
1 file changed, 7 insertions(+)
Index: b/drivers/scsi/device_handler/scsi_dh_alua.c
===================================================================
--- a/drivers/scsi/device_handler/scsi_dh_alua.c 2014-11-06 14:01:37.682079047 -0600
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c 2014-11-06 14:04:08.772079175 -0600
@@ -474,6 +474,13 @@ static int alua_check_sense(struct scsi_
* LUN Not Ready -- Offline
*/
return SUCCESS;
+ if (sdev->allow_restart &&
+ sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x02)
+ /*
+ * if the device is not started, we need to wake
+ * the error handler to start the motor
+ */
+ return FAILED;
break;
case UNIT_ATTENTION:
if (sense_hdr->asc == 0x29 && sense_hdr->ascq == 0x00)
--
next prev parent reply other threads:[~2014-11-06 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 21:11 [ V3 PATCH 0/2] TUR path is down after adapter gets reset in multipath configuration wenxiong
2014-11-06 21:11 ` [ V3 PATCH 1/2] scsi: call device handler for failed TUR command wenxiong
2014-11-07 8:52 ` Hannes Reinecke
2014-11-06 21:11 ` wenxiong [this message]
2014-11-07 8:53 ` [ V3 PATCH 2/2] scsi: TUR path is down after adapter gets reset with multipath Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106211336.369139152@linux.vnet.ibm.com \
--to=wenxiong@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.