From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Anatol Pomozov
<anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Marc Zyngier <Marc.Zyngier-5wv7dgnIgG8@public.gmane.org>,
Lorenzo Pieralisi
<Lorenzo.Pieralisi-5wv7dgnIgG8@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree
Date: Fri, 7 Nov 2014 10:40:26 +0000 [thread overview]
Message-ID: <20141107104025.GC4585@leverpostej> (raw)
In-Reply-To: <545C4783.8070506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote:
> On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
> > +Stephen
> >
> > This patch is for tegra20_timer that uses register_persistent_clock().
> > I did not find any way to share the same arch code for arm/arm64.
> >
> > Actually this register_persistent_clock() does not look arm specific
> > at all. Would it be better to move it somewhere outside of arch/?
>
> No CC to linux-tegra@ or the other Tegra maintainers?
>
> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
> the same code into multiple places.
Agreed. This looks in no way architecture specific, and having this in
common code would be preferable to copying.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Anatol Pomozov <anatol.pomozov@gmail.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree
Date: Fri, 7 Nov 2014 10:40:26 +0000 [thread overview]
Message-ID: <20141107104025.GC4585@leverpostej> (raw)
In-Reply-To: <545C4783.8070506@nvidia.com>
On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote:
> On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
> > +Stephen
> >
> > This patch is for tegra20_timer that uses register_persistent_clock().
> > I did not find any way to share the same arch code for arm/arm64.
> >
> > Actually this register_persistent_clock() does not look arm specific
> > at all. Would it be better to move it somewhere outside of arch/?
>
> No CC to linux-tegra@ or the other Tegra maintainers?
>
> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
> the same code into multiple places.
Agreed. This looks in no way architecture specific, and having this in
common code would be preferable to copying.
Mark.
next prev parent reply other threads:[~2014-11-07 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 0:21 [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree Anatol Pomozov
2014-11-07 0:25 ` Anatol Pomozov
[not found] ` <CAOMFOmXDqhwCk1pRf_9yGycboMqt-ZE33y=kZrhbqXOjVcrxYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 4:16 ` Stephen Warren
2014-11-07 4:16 ` Stephen Warren
[not found] ` <545C4783.8070506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-07 10:40 ` Mark Rutland [this message]
2014-11-07 10:40 ` Mark Rutland
2014-11-07 16:24 ` Anatol Pomozov
2014-11-07 16:24 ` Anatol Pomozov
[not found] ` <CAOMFOmWfgtN+Q-sbQUS8-90pTrtk5Du8xkDVXaed=teVPb8sbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 16:38 ` Mark Rutland
2014-11-07 16:38 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107104025.GC4585@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=Lorenzo.Pieralisi-5wv7dgnIgG8@public.gmane.org \
--cc=Marc.Zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.