From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ptrace: add generic SET_SYSCALL request
Date: Fri, 7 Nov 2014 11:55:51 +0000 [thread overview]
Message-ID: <20141107115551.GC18916@arm.com> (raw)
In-Reply-To: <1977974.l97vvy7Y8b@wuerfel>
On Fri, Nov 07, 2014 at 09:30:53AM +0000, Arnd Bergmann wrote:
> On Friday 07 November 2014 16:47:23 AKASHI Takahiro wrote:
> > This patch adds a new generic ptrace request, PTRACE_SET_SYSCALL.
> > It can be used to change a system call number as follows:
> > ret = ptrace(pid, PTRACE_SET_SYSCALL, null, new_syscall_no);
> > 'new_syscall_no' can be -1 to skip this system call, you need to modify
> > a register's value, in arch-specific way, as return value though.
> >
> > Please note that we can't define PTRACE_SET_SYSCALL macro in
> > uapi/linux/ptrace.h partly because its value on arm, 23, is used as another
> > request on sparc.
> >
> > This patch also contains an example of change on arch side, arm.
> > Only syscall_set_nr() is required to be defined in asm/syscall.h.
> >
> > Currently only arm has this request, while arm64 would also have it
> > once my patch series of seccomp for arm64 is merged. It will also be
> > usable for most of other arches.
> > See the discussions in lak-ml:
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/300167.html
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> >
>
> Can you describe why you are moving the implementation? Is this a feature
> that we want to have on all architectures in the future? As you say,
> only arm32 implements is at the moment.
We need this for arm64 and, since all architectures seem to have a mechanism
for setting a system call via ptrace, moving it to generic code should make
sense for new architectures too, no?
We don't have any arch-specific ptrace requests on arm64, so it would be
a shame if we had to add one now, especially since there's nothing
conceptually arch-specific about setting a syscall number.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
"roland@hack.frob.com" <roland@hack.frob.com>,
"oleg@redhat.com" <oleg@redhat.com>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"keescook@chromium.org" <keescook@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dsaxena@linaro.org" <dsaxena@linaro.org>
Subject: Re: [RFC] ptrace: add generic SET_SYSCALL request
Date: Fri, 7 Nov 2014 11:55:51 +0000 [thread overview]
Message-ID: <20141107115551.GC18916@arm.com> (raw)
In-Reply-To: <1977974.l97vvy7Y8b@wuerfel>
On Fri, Nov 07, 2014 at 09:30:53AM +0000, Arnd Bergmann wrote:
> On Friday 07 November 2014 16:47:23 AKASHI Takahiro wrote:
> > This patch adds a new generic ptrace request, PTRACE_SET_SYSCALL.
> > It can be used to change a system call number as follows:
> > ret = ptrace(pid, PTRACE_SET_SYSCALL, null, new_syscall_no);
> > 'new_syscall_no' can be -1 to skip this system call, you need to modify
> > a register's value, in arch-specific way, as return value though.
> >
> > Please note that we can't define PTRACE_SET_SYSCALL macro in
> > uapi/linux/ptrace.h partly because its value on arm, 23, is used as another
> > request on sparc.
> >
> > This patch also contains an example of change on arch side, arm.
> > Only syscall_set_nr() is required to be defined in asm/syscall.h.
> >
> > Currently only arm has this request, while arm64 would also have it
> > once my patch series of seccomp for arm64 is merged. It will also be
> > usable for most of other arches.
> > See the discussions in lak-ml:
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/300167.html
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> >
>
> Can you describe why you are moving the implementation? Is this a feature
> that we want to have on all architectures in the future? As you say,
> only arm32 implements is at the moment.
We need this for arm64 and, since all architectures seem to have a mechanism
for setting a system call via ptrace, moving it to generic code should make
sense for new architectures too, no?
We don't have any arch-specific ptrace requests on arm64, so it would be
a shame if we had to add one now, especially since there's nothing
conceptually arch-specific about setting a syscall number.
Will
next prev parent reply other threads:[~2014-11-07 11:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 7:47 [RFC] ptrace: add generic SET_SYSCALL request AKASHI Takahiro
2014-11-07 7:47 ` AKASHI Takahiro
2014-11-07 9:30 ` Arnd Bergmann
2014-11-07 9:30 ` Arnd Bergmann
2014-11-07 11:55 ` Will Deacon [this message]
2014-11-07 11:55 ` Will Deacon
2014-11-07 12:03 ` Arnd Bergmann
2014-11-07 12:03 ` Arnd Bergmann
2014-11-07 12:11 ` Russell King - ARM Linux
2014-11-07 12:11 ` Russell King - ARM Linux
2014-11-07 12:44 ` Arnd Bergmann
2014-11-07 12:44 ` Arnd Bergmann
2014-11-07 13:11 ` Will Deacon
2014-11-07 13:11 ` Will Deacon
2014-11-07 14:30 ` Arnd Bergmann
2014-11-07 14:30 ` Arnd Bergmann
2014-11-07 16:44 ` Kees Cook
2014-11-07 16:44 ` Kees Cook
2014-11-07 23:05 ` Roland McGrath
2014-11-07 23:05 ` Roland McGrath
2014-11-07 12:27 ` Will Deacon
2014-11-07 12:27 ` Will Deacon
2014-11-10 6:36 ` AKASHI Takahiro
2014-11-10 6:36 ` AKASHI Takahiro
2014-11-07 14:04 ` Oleg Nesterov
2014-11-07 14:04 ` Oleg Nesterov
2014-11-12 10:46 ` AKASHI Takahiro
2014-11-12 10:46 ` AKASHI Takahiro
2014-11-12 11:00 ` Will Deacon
2014-11-12 11:00 ` Will Deacon
2014-11-12 11:06 ` AKASHI Takahiro
2014-11-12 11:06 ` AKASHI Takahiro
2014-11-12 11:13 ` Will Deacon
2014-11-12 11:13 ` Will Deacon
2014-11-12 11:19 ` Arnd Bergmann
2014-11-12 11:19 ` Arnd Bergmann
2014-11-12 12:05 ` Russell King - ARM Linux
2014-11-12 12:05 ` Russell King - ARM Linux
2014-11-13 7:02 ` AKASHI Takahiro
2014-11-13 7:02 ` AKASHI Takahiro
2014-11-13 10:21 ` Arnd Bergmann
2014-11-13 10:21 ` Arnd Bergmann
2014-11-13 14:49 ` Ulrich Weigand
2014-11-13 14:49 ` Ulrich Weigand
2014-11-13 22:25 ` Arnd Bergmann
2014-11-13 22:25 ` Arnd Bergmann
2014-11-14 1:40 ` AKASHI Takahiro
2014-11-14 1:40 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107115551.GC18916@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.