All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] spi: Add designware master SPI DM driver used on SoCFPGA
Date: Fri, 7 Nov 2014 16:12:05 +0100	[thread overview]
Message-ID: <201411071612.05847.marex@denx.de> (raw)
In-Reply-To: <1415364634-8290-4-git-send-email-sr@denx.de>

On Friday, November 07, 2014 at 01:50:31 PM, Stefan Roese wrote:
> This patch adds the driver for the Designware master SPI controller. This
> IP core is integrated on the Altera SoCFPGA. This implementation is a
> driver model (DM) implementation. So multiple SPI drivers can be used.
> Thats necessary, since SoCFPGA also integrates the Cadence QSPI controller
> used to connect the SPI NOR flashes. Without DM, using multiple SPI
> driver is not possible.
> 
> This driver is very loosly based on the Linux driver. Most of the Linux
> driver is removed. Only the polling loop for the transfer is really used
> from this driver. As we don't support interrupts and DMA right now.
> 
> This is tested on the SoCrates SoCFPGA board using the SPI pins on the
> P14 header.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Vince Bridgers <vbridger@altera.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>

[...]

> diff --git a/drivers/spi/designware_spi.c b/drivers/spi/designware_spi.c
> new file mode 100644
> index 0000000..1bc0d04
> --- /dev/null
> +++ b/drivers/spi/designware_spi.c
> @@ -0,0 +1,425 @@
> +/*
> + * Designware master SPI core controller driver
> + *
> + * Copyright (C) 2014 Stefan Roese <sr@denx.de>
> + *
> + * Very loosly based on the Linux driver version which is:
> + * Copyright (c) 2009, Intel Corporation.
> + *
> + * SPDX-License-Identifier:	GPL-2.0

What's the agreement about the licensing now, GPL-2.0 or GPL-2.0+ ?

[...]

> +static inline u32 dw_readl(struct dw_spi_priv *priv, u32 offset)
> +{
> +	return __raw_readl(priv->regs + offset);
> +}

Do we really need these wrappers ?

[...]

Thanks!

  reply	other threads:[~2014-11-07 15:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 12:50 [U-Boot] [PATCH 0/6] arm: socfpga: Add Designware SPI support Stefan Roese
2014-11-07 12:50 ` [U-Boot] [PATCH 1/6] arm: socfpga: Add DW master SPI clock to clock_manager.c Stefan Roese
2014-11-07 15:08   ` Marek Vasut
2014-11-12 17:41   ` Pavel Machek
2014-11-07 12:50 ` [U-Boot] [PATCH 2/6] arm: socfpga: Add socfpga_spim_enable() to reset_manager.c Stefan Roese
2014-11-12 17:42   ` Pavel Machek
2014-11-16 10:47     ` Stefan Roese
2014-11-07 12:50 ` [U-Boot] [PATCH 3/6] spi: Add designware master SPI DM driver used on SoCFPGA Stefan Roese
2014-11-07 15:12   ` Marek Vasut [this message]
2014-11-07 18:01   ` Simon Glass
2014-11-12 17:51   ` Pavel Machek
2014-11-14 20:16     ` Marek Vasut
2014-11-15 13:33       ` Stefan Roese
2014-11-15 14:40         ` Marek Vasut
2014-11-07 12:50 ` [U-Boot] [PATCH 4/6] arm: socfpga: dts: Add spi0/1 dts nodes for the Designware master SPI devices Stefan Roese
2014-11-12 17:52   ` Pavel Machek
2014-11-07 12:50 ` [U-Boot] [PATCH 5/6] arm: socfpga: dts: socrates: Add spi1/2 aliases needed DM SPI probing Stefan Roese
2014-11-12 17:52   ` Pavel Machek
2014-11-07 12:50 ` [U-Boot] [PATCH 6/6] arm: socfpga: Add Designware (DW) SPI support to config header Stefan Roese
2014-11-12 17:53   ` Pavel Machek
2014-11-14 20:18     ` Marek Vasut
2014-11-15 13:35       ` Stefan Roese
2014-11-15 14:40         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201411071612.05847.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.