All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Mark fastboot as unsafe
Date: Fri, 7 Nov 2014 18:41:16 +0100	[thread overview]
Message-ID: <20141107174116.GH6135@phenom.ffwll.local> (raw)
In-Reply-To: <1415111397-6604-1-git-send-email-daniel.vetter@ffwll.ch>

On Tue, Nov 04, 2014 at 03:29:57PM +0100, Daniel Vetter wrote:
> Fastboot in its current incarnation assumes that the pfit isn't
> relevatn for the state and that it can be disabled without restarting
> the crtc. Unfortunately that's not the case on gen2/3 - it upsets the
> hw and results in a black screen.
> 
> Worse, the way the current fastboot hack is structure we can't detect
> and work around this in the code, since the fastboot smashes the
> adjusted mode into crtc->mode. Which means the higher levels can't
> correctly figure out that this is a lie and act accordingly.
> 
> Since fastboot is just a tech demo let's mark the module option as
> experimental and close the coresponding reports as wontfix.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84682
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Jesse expressed concerns in private about this patch, so I've dropped it
and the other fastboot patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2014-11-07 17:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 14:29 [PATCH] drm/i915: Mark fastboot as unsafe Daniel Vetter
2014-11-04 23:03 ` Paul Menzel
2014-11-07 17:41 ` Daniel Vetter [this message]
2014-11-10 18:06   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141107174116.GH6135@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.