From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: "Kyösti Mälkki" <kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/2] usb: gadget dbgp: Fix endpoint config after USB disconnect
Date: Fri, 7 Nov 2014 12:04:53 -0600 [thread overview]
Message-ID: <20141107180453.GM15036@saruman> (raw)
In-Reply-To: <1415027885-2181-2-git-send-email-kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Mon, Nov 03, 2014 at 05:18:04PM +0200, Kyösti Mälkki wrote:
> SET_FEATURE request with DEBUG_MODE only worked the first time after module
> initialisation. Per the USB 2.0 debug device specification, said request
> is to be treated as if it were a SET_CONFIGURATION request, i.e. endpoint
> must be re-configured.
>
> As configure_endpoints() may now get called multiple times, move it outside
> __init and move serial_alloc_tty() call into __init.
>
> Code has assumption that endpoint mapping remains unchanged with consecutive
> calls of configure_endpoints().
>
> Signed-off-by: Kyösti Mälkki <kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
if there are no comments here, I'll add this one to my testing/next.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-07 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1414346490-19307-1-git-send-email-kyosti.malkki@gmail.com>
[not found] ` <1414346490-19307-3-git-send-email-kyosti.malkki@gmail.com>
[not found] ` <1414346490-19307-3-git-send-email-kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-27 13:38 ` [PATCH 2/2] usb: gadget serial: Honour termios CLOCAL on disconnect Felipe Balbi
2014-10-27 15:43 ` Kyösti Mälkki
[not found] ` <544E680A.9010700-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-27 15:46 ` Felipe Balbi
2014-10-27 17:11 ` Peter Hurley
2014-11-03 15:18 ` usb: gadget: Fixes to receive from USB EHCI Debug Kyösti Mälkki
[not found] ` <1415027885-2181-1-git-send-email-kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-03 15:18 ` [PATCH v2 1/2] usb: gadget dbgp: Fix endpoint config after USB disconnect Kyösti Mälkki
[not found] ` <1415027885-2181-2-git-send-email-kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-07 18:04 ` Felipe Balbi [this message]
2014-11-03 15:18 ` [PATCH v2 2/2] usb: gadget serial: Honour termios CLOCAL on disconnect Kyösti Mälkki
[not found] ` <1415027885-2181-3-git-send-email-kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-03 15:33 ` Peter Hurley
[not found] ` <5457A062.50306-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2014-11-03 23:49 ` Kyösti Mälkki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107180453.GM15036@saruman \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.