From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Liam Girdwood <lgirdwood@gmail.com>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] ASoC: wm9712/wm9713: Replace virtual registers with custom put/get callbacks
Date: Sat, 8 Nov 2014 12:43:12 +0000 [thread overview]
Message-ID: <20141108124312.GZ23178@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <545C9678.2050203@metafoo.de>
On Fri, Nov 07, 2014 at 10:52:56AM +0100, Lars-Peter Clausen wrote:
> On 11/03/2014 07:33 PM, Lars-Peter Clausen wrote:
>> The wm9712/wm9713 has separate mixers for the left and the right channel,
>> but the inputs to the mixers are enabled/disabled by the same control.
>> Currently this is implemented by the driver by registering two virtual
>> controls for each physical control, one for the left mixer and one for the
>> right mixer.
>>
>> Using virtual registers will no longer work when the driver has
>> been converted to regmap. This patch converts the driver to use controls
>> with custom put/get callbacks instead which implement the logic making sure
>> that the physical control is unmuted when either the left or the right
>> control is unmuted.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
> Hi Charles,
>
> Given your usual fast responses on patches I'm suspecting that this one
> may have been lost. If not I apologize for the noise.
>
> Thanks,
> - Lars
Apologies for that, it must have come in on a busy morning and
then I forgot to come back to it.
All looks good to me and seems Mark has applied it now.
Thanks,
Charles
next prev parent reply other threads:[~2014-11-08 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 18:33 [PATCH 0/2] ASoC: More AC'97 cleanups Lars-Peter Clausen
2014-11-03 18:33 ` [PATCH 1/2] ASoC: mioa701_wm9713: Don't opencode CODEC register access Lars-Peter Clausen
2014-11-04 11:49 ` Mark Brown
2014-11-03 18:33 ` [PATCH 2/2] ASoC: wm9712/wm9713: Replace virtual registers with custom put/get callbacks Lars-Peter Clausen
2014-11-07 9:52 ` Lars-Peter Clausen
2014-11-08 12:43 ` Charles Keepax [this message]
2014-11-08 9:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141108124312.GZ23178@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.