From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3 2/4] input: alps: Allow 2 invalid packets without resetting device Date: Sat, 8 Nov 2014 13:00:34 -0800 Message-ID: <20141108210034.GC40319@dtor-ws> References: <1412329392-5580-1-git-send-email-pali.rohar@gmail.com> <1414884310-19842-1-git-send-email-pali.rohar@gmail.com> <1414884310-19842-3-git-send-email-pali.rohar@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f179.google.com ([209.85.223.179]:50291 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbaKHVAj (ORCPT ); Sat, 8 Nov 2014 16:00:39 -0500 Content-Disposition: inline In-Reply-To: <1414884310-19842-3-git-send-email-pali.rohar@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Hans de Goede , Yunkang Tang , Tommy Will , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Nov 02, 2014 at 12:25:08AM +0100, Pali Roh=E1r wrote: > On some Dell Latitude laptops ALPS device or Dell EC send one invalid= byte in > 6 bytes ALPS packet. In this case psmouse driver enter out of sync st= ate. It > looks like that all other bytes in packets are valid and also device = working > properly. So there is no need to do full device reset, just need to w= ait > for byte which match condition for first byte (start of packet). Beca= use ALPS > packets are bigger (6 or 8 bytes) default limit is small. >=20 > This patch increase number of invalid bytes to size of 2 ALPS packets= which > psmouse driver can drop before do full reset. >=20 > Resetting ALPS devices take some time and when doing reset on some De= ll laptops > touchpad, trackstick and also keyboard do not respond. So it is bette= r to do it > only if really necessary. >=20 > Signed-off-by: Pali Roh=E1r > Tested-by: Pali Roh=E1r > Cc: stable@vger.kernel.org Applied, thank you. > --- > drivers/input/mouse/alps.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index a772745..7c47e97 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -2391,6 +2391,9 @@ int alps_init(struct psmouse *psmouse) > /* We are having trouble resyncing ALPS touchpads so disable it for= now */ > psmouse->resync_time =3D 0; > =20 > + /* Allow 2 invalid packets without resetting device */ > + psmouse->resetafter =3D psmouse->pktsize * 2; > + > return 0; > =20 > init_fail: > --=20 > 1.7.9.5 >=20 --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbaKHVAm (ORCPT ); Sat, 8 Nov 2014 16:00:42 -0500 Received: from mail-ie0-f179.google.com ([209.85.223.179]:50291 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbaKHVAj (ORCPT ); Sat, 8 Nov 2014 16:00:39 -0500 Date: Sat, 8 Nov 2014 13:00:34 -0800 From: Dmitry Torokhov To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Hans de Goede , Yunkang Tang , Tommy Will , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] input: alps: Allow 2 invalid packets without resetting device Message-ID: <20141108210034.GC40319@dtor-ws> References: <1412329392-5580-1-git-send-email-pali.rohar@gmail.com> <1414884310-19842-1-git-send-email-pali.rohar@gmail.com> <1414884310-19842-3-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1414884310-19842-3-git-send-email-pali.rohar@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 02, 2014 at 12:25:08AM +0100, Pali Rohár wrote: > On some Dell Latitude laptops ALPS device or Dell EC send one invalid byte in > 6 bytes ALPS packet. In this case psmouse driver enter out of sync state. It > looks like that all other bytes in packets are valid and also device working > properly. So there is no need to do full device reset, just need to wait > for byte which match condition for first byte (start of packet). Because ALPS > packets are bigger (6 or 8 bytes) default limit is small. > > This patch increase number of invalid bytes to size of 2 ALPS packets which > psmouse driver can drop before do full reset. > > Resetting ALPS devices take some time and when doing reset on some Dell laptops > touchpad, trackstick and also keyboard do not respond. So it is better to do it > only if really necessary. > > Signed-off-by: Pali Rohár > Tested-by: Pali Rohár > Cc: stable@vger.kernel.org Applied, thank you. > --- > drivers/input/mouse/alps.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index a772745..7c47e97 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -2391,6 +2391,9 @@ int alps_init(struct psmouse *psmouse) > /* We are having trouble resyncing ALPS touchpads so disable it for now */ > psmouse->resync_time = 0; > > + /* Allow 2 invalid packets without resetting device */ > + psmouse->resetafter = psmouse->pktsize * 2; > + > return 0; > > init_fail: > -- > 1.7.9.5 > -- Dmitry