From: Dave Chinner <david@fromorbit.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] btrfs: regression test for btrfs extent merge
Date: Mon, 10 Nov 2014 12:35:34 +1100 [thread overview]
Message-ID: <20141110013534.GM28565@dastard> (raw)
In-Reply-To: <543F8286.4060200@cn.fujitsu.com>
On Thu, Oct 16, 2014 at 04:32:06PM +0800, Qu Wenruo wrote:
> -------- Original Message --------
> Subject: Re: [PATCH] btrfs: regression test for btrfs extent merge
> From: Eryu Guan <eguan@redhat.com>
> >>+
> >>+tmp=`mktemp -d`
> >I'm a bit concerned about this. Some functions in common/rc use
> >$tmp.some_sufix as temp file. If $tmp defined as a dir here, I'm not
> >sure if it will cause any trouble.
> It seems that most tests uses /tmp/$$ as tmp, only some exception
> like btrfs/077 uses mktemp -d.
> So I'd better use the old /tmp/$$ method.
Can you please send a patch to fix btrfs/077 as well?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-11-10 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 1:42 [PATCH] btrfs: regression test for btrfs extent merge Qu Wenruo
2014-10-16 1:42 ` Qu Wenruo
2014-10-16 7:44 ` Filipe David Manana
2014-10-16 8:13 ` Eryu Guan
2014-10-16 8:32 ` Qu Wenruo
2014-10-16 8:32 ` Qu Wenruo
2014-11-10 1:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110013534.GM28565@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.