Re: [PATCH v3 3/4] net: phy: Support Marvell 88EE1543 PHY

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Ezequiel,

On Sun, Nov 09, 2014 at 11:56:17AM -0300, Ezequiel Garcia wrote:
> This commit adds support for Marvell's 88E1543 PHY chip. This chip is
> almost identical to the 88EE1545, except the 88E1545 supports QSGMII
> and the 88EE1543 supports SGMII.
> 
> Therefore, the same configuration function is used for both PHYs. For now,
> the only initialization provided for the 88EE1543 is the LED setup.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  drivers/net/phy/marvell.c   | 9 +++++++++
>  include/linux/marvell_phy.h | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 3ea72e2..3248b48 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -233,6 +233,15 @@ static struct phy_driver marvell_phys[] = {
>  	.config_aneg	= genphy_config_aneg,
>  	.read_status	= marvell_read_status,
>  },
> +{
> +	.phy_id		= MARVELL_PHY_ID_88E1543,
> +	.phy_id_mask	= MARVELL_PHY_ID_MASK,
> +	.drv.name	= "Marvell 88E1543",
> +	.features	= PHY_GBIT_FEATURES,
> +	.config_init	= m88e1540_config_init,
> +	.config_aneg	= genphy_config_aneg,
> +	.read_status	= marvell_read_status,
> +},
>  };

Could you fix the indentation before adding more elements to this array?
It should be

static struct phy_driver marvell_phys[] = {
	{
		...
	},
};

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox