From: Jan Kara <jack@suse.cz>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH 3/3] fsnotify: Remove destroy_list from fsnotify_mark
Date: Mon, 10 Nov 2014 11:30:50 +0100 [thread overview]
Message-ID: <20141110103050.GF15948@quack.suse.cz> (raw)
In-Reply-To: <545BE56C.5080502@gmx.de>
On Thu 06-11-14 22:17:32, Heinrich Schuchardt wrote:
> On 06.11.2014 14:03, Jan Kara wrote:
> >destroy_list is used to track marks which still need waiting for srcu
> >period end before they can be freed. However by the time mark is added
> >to destroy_list it isn't in group's list of marks anymore and thus we
> >can reuse fsnotify_mark->g_list for queueing into destroy_list. This
> >saves two pointers for each fsnotify_mark.
>
> With your patch the information how g_list is used is only provided
> in the commit message (same is true for obj_list in PATCH 2/3).
>
> Please, provide comments for the fields of structure fsnotify_mark
> in include/linux/fsnotify_backend.h indicating how these fields are
> used.
>
> Especially if a field is reused for different purposes, as you now
> suggest for g_list (and obj_list), this information is
> indispensable.
Good point. I'll update the comments and resend. Thanks.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-11-10 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 13:03 [PATCH 0/3] fsnotify: Cleanups Jan Kara
2014-11-06 13:03 ` [PATCH 1/3] fsnotify: Unify inode and mount marks handling Jan Kara
2014-11-06 13:03 ` [PATCH 2/3] fsnotify: Remove free_list list_head from fsnotify_mark Jan Kara
2014-11-06 13:03 ` [PATCH 3/3] fsnotify: Remove destroy_list " Jan Kara
2014-11-06 21:17 ` Heinrich Schuchardt
2014-11-10 10:30 ` Jan Kara [this message]
2014-11-10 12:54 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110103050.GF15948@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.