From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 10 Nov 2014 19:32:24 +0100 (CET) Received: from mail.linuxfoundation.org ([140.211.169.12]:37370 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27013230AbaKJScWSYQLH (ORCPT ); Mon, 10 Nov 2014 19:32:22 +0100 Received: from localhost (unknown [59.10.106.2]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7352A98F; Mon, 10 Nov 2014 18:32:14 +0000 (UTC) Date: Tue, 11 Nov 2014 03:30:56 +0900 From: Greg Kroah-Hartman To: Kevin Cernekee Cc: Rob Herring , Jiri Slaby , Grant Likely , Florian Fainelli , Maxime Bizon , Jonas Gorski , Linux-MIPS , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , stable@vger.kernel.org Subject: Re: [PATCH 2/2] tty: serial: bcm63xx: Allow device nodes to be renamed to /dev/ttyBCM* Message-ID: <20141110183056.GA14178@kroah.com> References: <1415523348-4631-1-git-send-email-cernekee@gmail.com> <1415523348-4631-2-git-send-email-cernekee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43965 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: gregkh@linuxfoundation.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, Nov 10, 2014 at 07:05:14AM -0800, Kevin Cernekee wrote: > On Mon, Nov 10, 2014 at 6:25 AM, Rob Herring wrote: > > On Sun, Nov 9, 2014 at 2:55 AM, Kevin Cernekee wrote: > >> By default, bcm63xx_uart.c uses the standard 8250 device naming and > >> major/minor numbers. There are at least two situations where this could > >> be a problem: > >> > >> 1) Multiplatform kernels that need to support some chips that have 8250 > >> UARTs and other chips that have bcm63xx UARTs. > >> > >> 2) Some older chips like BCM7125 have a mix of both UART types. > >> > >> Add a new Kconfig option to tell the driver whether to register itself > >> as ttyS or ttyBCM. By default it will retain the existing "ttyS" > >> behavior to avoid surprises. > > > > While I understand the desire to have stable names, this is the > > opposite direction we want to go. Per platform tty names complicates > > having a generic userspace. It is not so bad since most ARM platforms > > use ttyS or ttyAMA, but just think what the kernel and userspace side > > would look like if every single platform did this. We can't change > > everything to ttyS because the other names are already an ABI. > > > > This can be solved with a udev rule to create sym links. > > Is it safe to register two console drivers named "ttyS" with the same > major/minor numbers? Not at all, think about what you are asking for here. Is the kernel allowed to register two block devices with the same major/minor numbers? greg k-h