All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/4] elfutils: adapt patches to the new version
Date: Mon, 10 Nov 2014 19:31:07 +0100	[thread overview]
Message-ID: <20141110193107.32b39449@free-electrons.com> (raw)
In-Reply-To: <1415637521-57583-4-git-send-email-Vincent.Riera@imgtec.com>

Dear Vicente Olivert Riera,

On Mon, 10 Nov 2014 16:38:40 +0000, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/elfutils/0001-disable-progs.patch |   54 +++++++-------
>  package/elfutils/0002-argp-support.patch  |  120 ++++++++++++++--------------
>  package/elfutils/0003-memcpy-def.patch    |   15 ++--
>  package/elfutils/0004-fts.patch           |   69 ++++++++---------
>  package/elfutils/0005-disable-po.patch    |   25 +++---
>  5 files changed, 141 insertions(+), 142 deletions(-)

You still don't seem to understand what "bisectability" means. It means
that your series should *work* at each point of the series.

Here, if we apply patches 1 and 2 of your series, but leave patches 3
and 4 unapplied, the build will break, because patch 2 has changed the
version of elfutils being used, but changes of patch 3 are not present,
so the patches of elfutils will not apply.

Do the test yourself: apply just your patches 1 and 2, and test the
build of elfutils.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-11-10 18:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 16:38 [Buildroot] [PATCH v2 0/4] elfutils: version bump Vicente Olivert Riera
2014-11-10 16:38 ` [Buildroot] [PATCH v2 1/4] elfutils: rename patches to follow the new name structure Vicente Olivert Riera
2014-11-10 16:38 ` [Buildroot] [PATCH v2 2/4] elfutils: bump version to 0.160 Vicente Olivert Riera
2014-11-10 16:38 ` [Buildroot] [PATCH v2 3/4] elfutils: adapt patches to the new version Vicente Olivert Riera
2014-11-10 18:31   ` Thomas Petazzoni [this message]
2014-11-10 16:38 ` [Buildroot] [PATCH v2 4/4] elfutils: really make -Werror conditional to BUILD_WERROR Vicente Olivert Riera
2014-11-10 16:56   ` Vicente Olivert Riera
2014-11-10 18:46 ` [Buildroot] [PATCH v2 0/4] elfutils: version bump Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141110193107.32b39449@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.