All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Giedrius Statkevicius <giedriuswork@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, jim.epost@gmail.com
Subject: Re: [PATCH] platform: hp_accel: Add SERIO_I8042 as a dependency since it now includes i8042.h/serio.h
Date: Mon, 10 Nov 2014 21:16:04 -0800	[thread overview]
Message-ID: <20141111051603.GA56947@vmdeb7> (raw)
In-Reply-To: <1415645982-9472-1-git-send-email-giedriuswork@gmail.com>

On Mon, Nov 10, 2014 at 08:59:42PM +0200, Giedrius Statkevicius wrote:
> Make hp_accel dependent on SERIO_I8042 in the Kconfig because since commit
> a4c724d0723b078e4ab4670e557cda1795036a7a ('platform: hp_accel: add a i8042
> filter to remove HPQ6000 data from kb bus stream') hp_accel includes i8042.h
> and serio.h.
> 
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 4dcfb71..7d146e68 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -202,6 +202,7 @@ config TC1100_WMI
>  config HP_ACCEL
>  	tristate "HP laptop accelerometer"
>  	depends on INPUT && ACPI
> +        depends on SERIO_I8042

Whitespace error, this should be a tab. I suggest making whitespace visible in
your editor to avoid this kind of thing.

I've corrected it and queued it.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center

      reply	other threads:[~2014-11-11  5:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 18:59 [PATCH] platform: hp_accel: Add SERIO_I8042 as a dependency since it now includes i8042.h/serio.h Giedrius Statkevicius
2014-11-11  5:16 ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111051603.GA56947@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=giedriuswork@gmail.com \
    --cc=jim.epost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.