All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: cxgb4: Cleanup macros so they follow the same style and look consistent, part 2
Date: Tue, 11 Nov 2014 13:06:01 +0000	[thread overview]
Message-ID: <20141111130601.GC19962@mwanda> (raw)

Hello Hariprasad Shenai,

The patch e2ac9628959c: "cxgb4: Cleanup macros so they follow the
same style and look consistent, part 2" from Nov 7, 2014, leads to
the following static checker warning:

	drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5756 adap_init0()
	info: ignoring unreachable code.

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
  5739                          if (ret < 0)
  5740                                  ret = adap_init0_no_config(adap, reset);
  5741                          else {
  5742                                  /*
  5743                                   * The firmware provides us with a memory
  5744                                   * buffer where we can load a Configuration
  5745                                   * File from the host if we want to override
  5746                                   * the Configuration File in flash.
  5747                                   */
  5748  
  5749                                  ret = adap_init0_config(adap, reset);
  5750                                  if (ret = -ENOENT) {
  5751                                          dev_info(adap->pdev_dev,
  5752                                              "No Configuration File present "
  5753                                              "on adapter. Using hard-wired "
  5754                                              "configuration parameters.\n");
  5755                                          goto bye;
                                                ^^^^^^^^

This looks like it was added to the commit accidentally.  It creates
a new static checker warning.

  5756                                          ret = adap_init0_no_config(adap, reset);
  5757                                  }
  5758                          }

regards,
dan carpenter

             reply	other threads:[~2014-11-11 13:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 13:06 Dan Carpenter [this message]
2014-11-12  8:43 ` cxgb4: Cleanup macros so they follow the same style and look consistent, part 2 Hariprasad S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111130601.GC19962@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.