From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 6/6] drm/i915: Remove most INVALID_PIPE checks from the backlight code
Date: Tue, 11 Nov 2014 15:39:14 +0100 [thread overview]
Message-ID: <20141111143914.GP25711@phenom.ffwll.local> (raw)
In-Reply-To: <871tpf16rb.fsf@intel.com>
On Fri, Nov 07, 2014 at 03:26:32PM +0200, Jani Nikula wrote:
> On Fri, 07 Nov 2014, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Now that the backlight device no longer gets registered too early we
> > should be able to drop most of the INVALID_PIPE checks from the backlight
> > code.
> >
> > The only exceptio is the opregion stuff where we may (in theory at
> > least) get a request from the BIOS already during driver init as soon as
> > the backlight setup has been done. In which case we can still get the
> > INVALID_PIPE from intel_get_pipe_from_connector(). So leave that check
> > in place, and add a comment explaining why.
> >
> > For the rest, if we still manage to get here with INVALID_PIPE on
> > VLV/CHV we will now get a WARN from the lower level functions and
> > can then actually investigate further.
> >
> > v2: Leave the check in the BIOS related code (Jani)
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Merged everything from this series, thanks for patches&review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-11 14:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 9:15 [PATCH 0/6] drm/i915: VLV/CHV backlight fixes ville.syrjala
2014-11-07 9:15 ` [PATCH 1/6] drm/i915: Warn if trying to poke a VLV backlight on invalid pipe ville.syrjala
2014-11-07 11:33 ` Jani Nikula
2014-11-07 9:16 ` [PATCH 2/6] drm/i915: Catch INVALID_PIPE in vlv_get_backlight() ville.syrjala
2014-11-07 11:32 ` Jani Nikula
2014-11-07 13:18 ` [PATCH v2 2/6] drm/i915: Skip .get_backlight() when backlight isn't enabled ville.syrjala
2014-11-07 13:24 ` Jani Nikula
2014-11-07 9:16 ` [PATCH 3/6] drm/i915: Don't deref NULL crtc in intel_get_pipe_from_connector() ville.syrjala
2014-11-07 11:32 ` Jani Nikula
2014-11-07 9:16 ` [PATCH 4/6] drm/i915: Pass the current pipe from eDP init to backlight setup ville.syrjala
2014-11-07 12:07 ` Jani Nikula
2014-11-07 9:16 ` [PATCH 5/6] drm/i915: Register the backlight device after the modeset init ville.syrjala
2014-11-07 12:19 ` Jani Nikula
2014-11-07 12:25 ` Jani Nikula
2014-11-07 13:19 ` [PATCH v2 " ville.syrjala
2014-11-07 13:25 ` Jani Nikula
2014-11-07 9:16 ` [PATCH 6/6] drm/i915: Remove most INVALID_PIPE checks from VLV backlight code ville.syrjala
2014-11-07 12:24 ` Jani Nikula
2014-11-07 12:51 ` Ville Syrjälä
2014-11-07 13:20 ` [PATCH v2 6/6] drm/i915: Remove most INVALID_PIPE checks from the " ville.syrjala
2014-11-07 13:26 ` Jani Nikula
2014-11-11 14:39 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111143914.GP25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.