From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Chen Gong <gong.chen@linux.intel.com>, X86 ML <x86@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Oleg Nesterov <oleg@redhat.com>, Tony Luck <tony.luck@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] x86/mce: Simplify flow when handling recoverable memory errors
Date: Tue, 11 Nov 2014 17:30:59 +0100 [thread overview]
Message-ID: <20141111163059.GH31490@pd.tnic> (raw)
In-Reply-To: <CALCETrWqGkNBCsPr5QLt4dQSH2mwDgN2tfKy7fqVG4ERZW8e2Q@mail.gmail.com>
On Tue, Nov 11, 2014 at 08:22:45AM -0800, Andy Lutomirski wrote:
> I think it's okay-ish, but only if it's necessary, and I still don't
> see why it's necessary.
>
> Can't you just remove TIF_MCE_NOTIFY entirely and just do all the
> mce_notify_process work directly in do_machine_check? IOW, why do you
> need to store any state per-task when it's already on the stack
> anyway.
I wish but memory_failure() can't run in #MC context as it noodles
quite a lot and grabs all kinds of locks and does a bunch of other
atomit-context-unsafe things.
And it needs to run *before* the process is killed as it looks at its
pages.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-11-11 16:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 6:49 x86, MCE: MCE event ring management Chen, Gong
2014-08-14 6:49 ` [PATCH v2 1/5] x86, MCE: Provide a lock-less memory pool to save error record Chen, Gong
2014-08-14 6:49 ` [PATCH v2 2/5] x86, MCE: Don't use percpu for MCE workqueue/irq_work Chen, Gong
2014-08-14 6:49 ` [PATCH v2 3/5] x86, MCE: Remove mce_ring for SRAO error Chen, Gong
2014-08-14 6:49 ` [PATCH v2 4/5] x86/mce: Simplify flow when handling recoverable memory errors Chen, Gong
2014-11-11 11:42 ` Borislav Petkov
2014-11-11 15:42 ` Andy Lutomirski
2014-11-11 16:13 ` Borislav Petkov
2014-11-11 16:22 ` Andy Lutomirski
2014-11-11 16:30 ` Borislav Petkov [this message]
2014-11-11 17:15 ` Andy Lutomirski
2014-11-11 18:22 ` Borislav Petkov
2014-11-11 18:34 ` Andy Lutomirski
2014-11-11 18:38 ` Borislav Petkov
2014-11-11 20:10 ` Andy Lutomirski
2014-11-12 17:20 ` Oleg Nesterov
2014-11-12 17:25 ` Andy Lutomirski
2014-11-12 17:27 ` Borislav Petkov
2014-08-14 6:49 ` [PATCH v2 5/5] x86, MCE: Avoid potential deadlock in MCE context Chen, Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111163059.GH31490@pd.tnic \
--to=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.