From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoGE2-0001P8-Lt for qemu-devel@nongnu.org; Tue, 11 Nov 2014 13:31:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoGDw-0007D4-HN for qemu-devel@nongnu.org; Tue, 11 Nov 2014 13:31:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoGDw-0007BH-9x for qemu-devel@nongnu.org; Tue, 11 Nov 2014 13:31:28 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sABIVRpL021269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 11 Nov 2014 13:31:27 -0500 Date: Tue, 11 Nov 2014 16:31:24 -0200 From: Eduardo Habkost Message-ID: <20141111183124.GC4985@thinpad.lan.raisama.net> References: <1415376280-14130-1-git-send-email-drjones@redhat.com> <1415376280-14130-3-git-send-email-drjones@redhat.com> <20141111124100.GA4985@thinpad.lan.raisama.net> <20141111143709.GA14394@hawk.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141111143709.GA14394@hawk.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: [...] > Below is a v2 I can post if it looks good to you. > > From: Andrew Jones > Date: Fri, 7 Nov 2014 15:45:07 +0100 > Subject: [PATCH v2] vl: sanity check cpu topology > > smp_parse allows partial or complete cpu topology to be given. > In either case there may be inconsistencies in the input which > are currently not sounding any alarms. In some cases the input > is even being silently corrected. Stop silently adjusting input > and abort when the complete cpu topology has been input, but > isn't correct. > > Signed-off-by: Andrew Jones After applying this patch: $ ./install/bin/qemu-system-x86_64 -smp 12 cpu topology: error: sockets (1) * cores (1) * threads (1) < smp_cpus (12) That is why I wanted to address the most obvious (and less risky) issues first (aborting only if all options were explicitly set), and touch automatic calculation later. -- Eduardo