From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RFC 1/2] mfd: qcom-rpm: Expose sleep state resources to clients Date: Tue, 11 Nov 2014 10:33:21 -0800 Message-ID: <20141111183319.GD16980@sonymobile.com> References: <1415659966-16200-1-git-send-email-bjorn.andersson@sonymobile.com> <1415659966-16200-2-git-send-email-bjorn.andersson@sonymobile.com> <20141111120457.GZ24004@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from seldrel01.sonyericsson.com ([212.209.106.2]:10067 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbaKKScx (ORCPT ); Tue, 11 Nov 2014 13:32:53 -0500 Content-Disposition: inline In-Reply-To: <20141111120457.GZ24004@x1> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lee Jones Cc: Stephen Boyd , David Collins , Lina Iyer , Mark Brown , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" On Tue 11 Nov 04:04 PST 2014, Lee Jones wrote: > On Mon, 10 Nov 2014, Bjorn Andersson wrote: > > > Resources exposed from the RPM have an "active state" that is used during > > normal operations and a "sleep state" that is used for HW assisted sleep > > modes. Expose this in the api to let client drivers set the "sleep > > state" as well. > > I assume you have users lined up which will request a sleeping state? > All users of this interface (regulators, clocks and bus scaling) will have to be able to specify this. [..] > > @@ -359,8 +361,7 @@ int qcom_rpm_write(struct qcom_rpm *rpm, int resource, u32 *buf, size_t count) > > RPM_CTRL_REG(rpm, RPM_REQ_SELECT + i)); > > } > > > > - writel_relaxed(RPM_ACTIVE_STATE, > > - RPM_CTRL_REG(rpm, RPM_REQUEST_CONTEXT)); > > + writel_relaxed(BIT(state), RPM_CTRL_REG(rpm, RPM_REQUEST_CONTEXT)); > > How are the state bits organised? > BIT(0) is active mode, BIT(1) is sleep mode, as specified below. I could add some sanity checking here if you would like to. [..] > > diff --git a/include/linux/mfd/qcom_rpm.h b/include/linux/mfd/qcom_rpm.h > > index a60798d..f0e70b2 100644 > > --- a/include/linux/mfd/qcom_rpm.h > > +++ b/include/linux/mfd/qcom_rpm.h > > +#define RPM_ACTIVE_STATE 0 > > +#define RPM_SLEEP_STATE 1 Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn.andersson@sonymobile.com (Bjorn Andersson) Date: Tue, 11 Nov 2014 10:33:21 -0800 Subject: [RFC 1/2] mfd: qcom-rpm: Expose sleep state resources to clients In-Reply-To: <20141111120457.GZ24004@x1> References: <1415659966-16200-1-git-send-email-bjorn.andersson@sonymobile.com> <1415659966-16200-2-git-send-email-bjorn.andersson@sonymobile.com> <20141111120457.GZ24004@x1> Message-ID: <20141111183319.GD16980@sonymobile.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue 11 Nov 04:04 PST 2014, Lee Jones wrote: > On Mon, 10 Nov 2014, Bjorn Andersson wrote: > > > Resources exposed from the RPM have an "active state" that is used during > > normal operations and a "sleep state" that is used for HW assisted sleep > > modes. Expose this in the api to let client drivers set the "sleep > > state" as well. > > I assume you have users lined up which will request a sleeping state? > All users of this interface (regulators, clocks and bus scaling) will have to be able to specify this. [..] > > @@ -359,8 +361,7 @@ int qcom_rpm_write(struct qcom_rpm *rpm, int resource, u32 *buf, size_t count) > > RPM_CTRL_REG(rpm, RPM_REQ_SELECT + i)); > > } > > > > - writel_relaxed(RPM_ACTIVE_STATE, > > - RPM_CTRL_REG(rpm, RPM_REQUEST_CONTEXT)); > > + writel_relaxed(BIT(state), RPM_CTRL_REG(rpm, RPM_REQUEST_CONTEXT)); > > How are the state bits organised? > BIT(0) is active mode, BIT(1) is sleep mode, as specified below. I could add some sanity checking here if you would like to. [..] > > diff --git a/include/linux/mfd/qcom_rpm.h b/include/linux/mfd/qcom_rpm.h > > index a60798d..f0e70b2 100644 > > --- a/include/linux/mfd/qcom_rpm.h > > +++ b/include/linux/mfd/qcom_rpm.h > > +#define RPM_ACTIVE_STATE 0 > > +#define RPM_SLEEP_STATE 1 Regards, Bjorn