From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 3/6] x86: Add support for the clwb instruction Date: Tue, 11 Nov 2014 20:19:04 +0100 Message-ID: <20141111191904.GA12555@pd.tnic> References: <1415731396-19364-1-git-send-email-ross.zwisler@linux.intel.com> <1415731396-19364-4-git-send-email-ross.zwisler@linux.intel.com> <20141111191239.GC31523@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.skyhub.de (mail.skyhub.de [78.46.96.112]) by gabe.freedesktop.org (Postfix) with ESMTP id EC7756E052 for ; Tue, 11 Nov 2014 11:19:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <20141111191239.GC31523@pd.tnic> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ross Zwisler Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Gleixner , H Peter Anvin , Ingo Molnar List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMTEsIDIwMTQgYXQgMDg6MTI6MzlQTSArMDEwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+ID4gKwkJCSAiLmJ5dGUgMHg2NjsgeHNhdmVvcHQgJVAwIiwKPiAKPiBIdWgsIFhT QVZFT1BUPyE/IFNob3VsZG4ndCB0aGF0IGJlIENMV0I/PwoKQmFoLCB0aGUgc2FtZSBvcGNvZGVz LCBvbmx5IDB4NjYgcHJlZml4IG1ha2VzIGl0IGludG8gQ0xXQi4gQ291bGQgdXNlIGEKY29tbWVu dCBJIGd1ZXNzLgoKLS0gClJlZ2FyZHMvR3J1c3MsCiAgICBCb3Jpcy4KClNlbnQgZnJvbSBhIGZh dCBjcmF0ZSB1bmRlciBteSBkZXNrLiBGb3JtYXR0aW5nIGlzIGZpbmUuCi0tCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbaKKTTN (ORCPT ); Tue, 11 Nov 2014 14:19:13 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57824 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbaKKTTJ (ORCPT ); Tue, 11 Nov 2014 14:19:09 -0500 Date: Tue, 11 Nov 2014 20:19:04 +0100 From: Borislav Petkov To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, H Peter Anvin , Ingo Molnar , Thomas Gleixner , David Airlie , dri-devel@lists.freedesktop.org, x86@kernel.org Subject: Re: [PATCH 3/6] x86: Add support for the clwb instruction Message-ID: <20141111191904.GA12555@pd.tnic> References: <1415731396-19364-1-git-send-email-ross.zwisler@linux.intel.com> <1415731396-19364-4-git-send-email-ross.zwisler@linux.intel.com> <20141111191239.GC31523@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20141111191239.GC31523@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 11, 2014 at 08:12:39PM +0100, Borislav Petkov wrote: > > + ".byte 0x66; xsaveopt %P0", > > Huh, XSAVEOPT?!? Shouldn't that be CLWB?? Bah, the same opcodes, only 0x66 prefix makes it into CLWB. Could use a comment I guess. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --