From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] sched/cputime: fix clock_nanosleep/clock_gettime inconsistency
Date: Wed, 12 Nov 2014 13:27:53 +0100 [thread overview]
Message-ID: <20141112122745.GB3250@redhat.com> (raw)
In-Reply-To: <20141112114538.GJ10476@twins.programming.kicks-ass.net>
On Wed, Nov 12, 2014 at 12:45:38PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 12, 2014 at 12:37:37PM +0100, Peter Zijlstra wrote:
>
> > Which would make the sample run ahead, making the sleep short. So would
> > something like the below not cure things?
>
> Before anyone asks, yes I tried running that 'reproducer' it doesn't.
I'd be surprised if the patch would help. Issue here happen at start of
cputimer. We set sum_sched_runtime value of cputimer using not yet
accounted threads runtime and then add that runtime values again to
running cputimer on tick, making it's sum_exec_runtime bigger than
actual threads runtime.
Stanislaw
next prev parent reply other threads:[~2014-11-12 12:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 10:29 [PATCH] sched/cputime: fix clock_nanosleep/clock_gettime inconsistency Stanislaw Gruszka
2014-11-12 11:15 ` Peter Zijlstra
2014-11-12 11:37 ` Peter Zijlstra
2014-11-12 11:45 ` Peter Zijlstra
2014-11-12 12:27 ` Stanislaw Gruszka [this message]
2014-11-12 12:52 ` Peter Zijlstra
2014-11-16 9:50 ` [tip:sched/urgent] sched/cputime: Fix cpu_timer_sample_group() double accounting tip-bot for Peter Zijlstra
2014-11-12 12:21 ` [PATCH] sched/cputime: fix clock_nanosleep/clock_gettime inconsistency Stanislaw Gruszka
2014-11-12 12:51 ` Peter Zijlstra
2014-11-12 15:58 ` [PATCH v2] " Stanislaw Gruszka
2014-11-12 16:06 ` Peter Zijlstra
2014-11-12 16:17 ` Stanislaw Gruszka
2014-11-12 17:12 ` Peter Zijlstra
2014-11-12 16:45 ` Peter Zijlstra
2014-11-12 16:53 ` Stanislaw Gruszka
2014-11-12 16:56 ` Peter Zijlstra
2014-11-16 9:50 ` [tip:sched/urgent] sched/cputime: Fix clock_nanosleep()/ clock_gettime() inconsistency tip-bot for Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112122745.GB3250@redhat.com \
--to=sgruszka@redhat.com \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.