From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Petr Mladek <pmladek@suse.cz>
Cc: Joe Perches <joe@perches.com>,
Steven Rostedt <rostedt@goodmis.org>,
Corey Minyard <minyard@acm.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org
Subject: Re: [PATCH -next 2/2] seq_putc: Convert to return void and convert uses too.
Date: Wed, 12 Nov 2014 13:29:00 +0100 [thread overview]
Message-ID: <20141112122900.GA1542@salvia> (raw)
In-Reply-To: <20141111134740.GB2567@pathway.suse.cz>
On Tue, Nov 11, 2014 at 02:47:40PM +0100, Petr Mladek wrote:
> On Mon 2014-11-10 10:58:57, Joe Perches wrote:
> > Using the return value of seq_putc is error-prone, so
> > make it return void instead.
> >
> > Reverse the logic in seq_putc to make it like seq_puts.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Reviewed-by: Petr Mladek <pmladek@suse.cz>
>
> The changes are correct. The show() functions should return 0
> even when there is an overflow. They are called by traverse()
> from seq_read() that might increase the buffer size and try again.
Just in case you need this for the netfilter chunks:
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks.
next prev parent reply other threads:[~2014-11-12 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 18:58 [PATCH -next 0/2] seq: Convert seq_puts and seq_putc to return void Joe Perches
[not found] ` <cover.1415645476.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2014-11-10 18:58 ` [PATCH -next 1/2] seq_puts: Convert to return void and convert uses too Joe Perches
2014-11-10 18:58 ` Joe Perches
2014-11-11 0:32 ` Mark Brown
2014-11-11 13:38 ` Petr Mladek
2014-11-10 18:58 ` [PATCH -next 2/2] seq_putc: " Joe Perches
2014-11-10 18:58 ` Joe Perches
2014-11-11 13:47 ` Petr Mladek
2014-11-12 12:29 ` Pablo Neira Ayuso [this message]
2014-11-12 15:25 ` Corey Minyard
2014-11-12 15:25 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112122900.GA1542@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.