From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 3/6] x86: Add support for the clwb instruction Date: Wed, 12 Nov 2014 13:39:09 +0100 Message-ID: <20141112123909.GD16807@pd.tnic> References: <1415731396-19364-1-git-send-email-ross.zwisler@linux.intel.com> <1415731396-19364-4-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.skyhub.de (mail.skyhub.de [78.46.96.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C5E46E2B1 for ; Wed, 12 Nov 2014 04:39:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <1415731396-19364-4-git-send-email-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ross Zwisler Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Gleixner , H Peter Anvin , Ingo Molnar List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMTEsIDIwMTQgYXQgMTE6NDM6MTNBTSAtMDcwMCwgUm9zcyBad2lzbGVyIHdy b3RlOgo+ICtzdGF0aWMgaW5saW5lIHZvaWQgY2x3Yih2b2xhdGlsZSB2b2lkICpfX3ApCj4gK3sK PiArCWFsdGVybmF0aXZlX2lvXzIoIi5ieXRlICIgX19zdHJpbmdpZnkoTk9QX0RTX1BSRUZJWCkg IjsgY2xmbHVzaCAlUDAiLAo+ICsJCQkgIi5ieXRlIDB4NjY7IGNsZmx1c2ggJVAwIiwKPiArCQkJ IFg4Nl9GRUFUVVJFX0NMRkxVU0hPUFQsCj4gKwkJCSAiLmJ5dGUgMHg2NjsgeHNhdmVvcHQgJVAw IiwKCkJ0dywgSSdtIGFmcmFpZCB5b3UncmUgZ29pbmcgdG8gaGF2ZSB0byBzcGVsbCBvdXQgdGhv c2UgbmV3IGluc3RydWN0aW9uCm1uZW1vbmljcyBhcyB0aGV5IGFyZW4ndCBzdXBwb3J0ZWQgYnkg b2xkZXIgY29tcGlsZXJzOgoKICBDQyAgICAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fY2FjaGUubwp7 c3RhbmRhcmQgaW5wdXR9OiBBc3NlbWJsZXIgbWVzc2FnZXM6CntzdGFuZGFyZCBpbnB1dH06NjM6 IEVycm9yOiBubyBzdWNoIGluc3RydWN0aW9uOiBgeHNhdmVvcHQgKCVyYXgpJwp7c3RhbmRhcmQg aW5wdXR9OjI0OTogRXJyb3I6IG5vIHN1Y2ggaW5zdHJ1Y3Rpb246IGB4c2F2ZW9wdCAoJXJkaSkn CntzdGFuZGFyZCBpbnB1dH06MjgzOiBFcnJvcjogbm8gc3VjaCBpbnN0cnVjdGlvbjogYHhzYXZl b3B0IC0xKCVyZHgpJwptYWtlWzFdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9kcm1fY2FjaGUub10g RXJyb3IgMQptYWtlOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9kcm1fY2FjaGUub10gRXJyb3IgMgpb Ym9yaXNAZXRjaDoxNDozNTo0MDprOjE0KS0+ICBnY2MgLS12ZXJzaW9uCmdjYyAoR0NDKSA0LjEu MiAyMDA2MTExNSAocHJlcmVsZWFzZSkgKERlYmlhbiA0LjEuMS0yMSkKClRoaXMgaXMgb24gYSB2 ZXJ5IG9sZCBndWVzdCBJIGhhdmUgd2hpY2ggaGFzIHRoaXMgZ2NjIGluIGl0IGFuZCB0aGUKa2Vy bmVsIHN1cHBvcnRzIGV2ZXJ5dGhpbmcgZ2NjID49IDMuMi4KCi0tIApSZWdhcmRzL0dydXNzLAog ICAgQm9yaXMuCgpTZW50IGZyb20gYSBmYXQgY3JhdGUgdW5kZXIgbXkgZGVzay4gRm9ybWF0dGlu ZyBpcyBmaW5lLgotLQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbaKLMjR (ORCPT ); Wed, 12 Nov 2014 07:39:17 -0500 Received: from mail.skyhub.de ([78.46.96.112]:32992 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbaKLMjQ (ORCPT ); Wed, 12 Nov 2014 07:39:16 -0500 Date: Wed, 12 Nov 2014 13:39:09 +0100 From: Borislav Petkov To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, H Peter Anvin , Ingo Molnar , Thomas Gleixner , David Airlie , dri-devel@lists.freedesktop.org, x86@kernel.org Subject: Re: [PATCH 3/6] x86: Add support for the clwb instruction Message-ID: <20141112123909.GD16807@pd.tnic> References: <1415731396-19364-1-git-send-email-ross.zwisler@linux.intel.com> <1415731396-19364-4-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1415731396-19364-4-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 11, 2014 at 11:43:13AM -0700, Ross Zwisler wrote: > +static inline void clwb(volatile void *__p) > +{ > + alternative_io_2(".byte " __stringify(NOP_DS_PREFIX) "; clflush %P0", > + ".byte 0x66; clflush %P0", > + X86_FEATURE_CLFLUSHOPT, > + ".byte 0x66; xsaveopt %P0", Btw, I'm afraid you're going to have to spell out those new instruction mnemonics as they aren't supported by older compilers: CC drivers/gpu/drm/drm_cache.o {standard input}: Assembler messages: {standard input}:63: Error: no such instruction: `xsaveopt (%rax)' {standard input}:249: Error: no such instruction: `xsaveopt (%rdi)' {standard input}:283: Error: no such instruction: `xsaveopt -1(%rdx)' make[1]: *** [drivers/gpu/drm/drm_cache.o] Error 1 make: *** [drivers/gpu/drm/drm_cache.o] Error 2 [boris@etch:14:35:40:k:14)-> gcc --version gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) This is on a very old guest I have which has this gcc in it and the kernel supports everything gcc >= 3.2. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --