From: Felipe Balbi <balbi@ti.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
"Linux USB Mailing List" <linux-usb@vger.kernel.org>
Subject: Re: usb: gadget: midi: f_midi_alloc() can be static
Date: Wed, 12 Nov 2014 09:00:57 -0600 [thread overview]
Message-ID: <20141112150057.GD641@saruman> (raw)
In-Reply-To: <20141112132824.GA27653@wfg-t540p.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1763 bytes --]
On Wed, Nov 12, 2014 at 09:28:24PM +0800, Fengguang Wu wrote:
> drivers/usb/gadget/function/f_midi.c:1072:21: sparse: symbol 'f_midi_alloc' was not declared. Should it be static?
> drivers/usb/gadget/legacy/gmidi.c:118:30: sparse: symbol 'fi_midi' was not declared. Should it be static?
> drivers/usb/gadget/legacy/gmidi.c:119:21: sparse: symbol 'f_midi' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
I'm taking this one, but next time please Cc linux-usb
> ---
> function/f_midi.c | 2 +-
> legacy/gmidi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/drivers/usb/gadget/function/f_midi.c
> ===================================================================
> --- linux.orig/drivers/usb/gadget/function/f_midi.c
> +++ linux/drivers/usb/gadget/function/f_midi.c
> @@ -1069,7 +1069,7 @@ static void f_midi_unbind(struct usb_con
> usb_free_all_descriptors(f);
> }
>
> -struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
> +static struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
> {
> struct f_midi *midi;
> struct f_midi_opts *opts;
> Index: linux/drivers/usb/gadget/legacy/gmidi.c
> ===================================================================
> --- linux.orig/drivers/usb/gadget/legacy/gmidi.c
> +++ linux/drivers/usb/gadget/legacy/gmidi.c
> @@ -115,8 +115,8 @@ static struct usb_gadget_strings *dev_st
> NULL,
> };
>
> -struct usb_function_instance *fi_midi;
> -struct usb_function *f_midi;
> +static struct usb_function_instance *fi_midi;
> +static struct usb_function *f_midi;
>
> static int __exit midi_unbind(struct usb_composite_dev *dev)
> {
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-11-12 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201411121904.vA8htDl2%fengguang.wu@intel.com>
2014-11-12 13:28 ` usb: gadget: midi: f_midi_alloc() can be static Fengguang Wu
2014-11-12 15:00 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112150057.GD641@saruman \
--to=balbi@ti.com \
--cc=andrzej.p@samsung.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.