From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD Date: Wed, 12 Nov 2014 10:16:24 -0500 Message-ID: <20141112151624.GB6017@laptop.dumpdata.com> References: <1415788771-16563-1-git-send-email-wei.liu2@citrix.com> <1415789784.25176.67.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1415789784.25176.67.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Nov 12, 2014 at 10:56:24AM +0000, Ian Campbell wrote: > On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote: > > ... otherwise when device add operation fails, the error message looks > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) > > device", which is not very helpful. > > Thanks. > > > > Signed-off-by: Wei Liu > > Acked-by: Ian Campbell Release-Acked-by: Konrad Rzeszutek Wilk > > > Cc: Ian Jackson > > --- > > tools/libxl/libxl.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > > index f7961f6..de23fec 100644 > > --- a/tools/libxl/libxl.c > > +++ b/tools/libxl/libxl.c > > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1) > > \ > > GCNEW(aodev); \ > > libxl__prepare_ao_device(ao, aodev); \ > > + aodev->action = LIBXL__DEVICE_ACTION_ADD; \ > > aodev->callback = device_addrm_aocomplete; \ > > aodev->update_json = true; \ > > libxl__device_##type##_add(egc, domid, type, aodev); \ > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel