From: Borislav Petkov <bp@suse.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Matt Fleming <matt.fleming@intel.com>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: BUG() at boot in __phys_addr with DEBUG_VIRTUAL
Date: Wed, 12 Nov 2014 18:25:13 +0100 [thread overview]
Message-ID: <20141112172513.GC17793@pd.tnic> (raw)
In-Reply-To: <54637AD5.6060300@intel.com>
On Wed, Nov 12, 2014 at 07:20:53AM -0800, Dave Hansen wrote:
> So perhaps efi_map_region() is handing an address from the EFI identity
> map down in here. __pa() gets called on it, but that fails since __pa()
> only works on the *KERNEL* identity map.
Grrr, yeah, so pageattr.c assumes the kernel pgd in some places still.
> I think we might actually need to walk the page tables in there. Even
> the pfn_range_is_mapped() code looks to be dealing with the kernel
> identity map.
Yep, pageattr.c should be taught to pay attention to cpa->pgd. Btw, we
do have lookup_address_in_pgd() there which should do the walking.
But before we do that: Matt, why do we need the kernel text mapped 1:1
in the EFI page table at all?
You've added this with
4f9dbcfc4029 ("x86/efi: Add mixed runtime services support")
AFAICT.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-11-12 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 23:19 BUG() at boot in __phys_addr with DEBUG_VIRTUAL Dave Hansen
2014-11-11 23:47 ` Borislav Petkov
2014-11-12 9:24 ` Matt Fleming
2014-11-12 14:57 ` Dave Hansen
2014-11-12 15:11 ` Borislav Petkov
2014-11-12 15:20 ` Dave Hansen
2014-11-12 17:25 ` Borislav Petkov [this message]
2014-11-13 10:36 ` Matt Fleming
2014-12-09 10:35 ` Borislav Petkov
2014-11-13 13:08 ` Matt Fleming
2015-01-27 21:37 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112172513.GC17793@pd.tnic \
--to=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.