From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: imx-sdma: clarify about firmware not found error
Date: Thu, 13 Nov 2014 09:28:16 +0800 [thread overview]
Message-ID: <20141113012814.GO2704@dragon> (raw)
In-Reply-To: <1415829869-6661-1-git-send-email-festevam@gmail.com>
On Wed, Nov 12, 2014 at 08:04:29PM -0200, Fabio Estevam wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> When a firmware cannot be found for the SDMA engine then we can
> continue with the internal ROM firmware.
>
> The meaning of this message is frequently asked for, so make clear
> that the driver still works with the internal ROM firmware and reduce
> the loglevel from err to info.
>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/dma/imx-sdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 99d8833..2c67da5 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1287,7 +1287,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
> unsigned short *ram_code;
>
> if (!fw) {
> - dev_err(sdma->dev, "firmware not found\n");
> + dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
> + /* In this case we just use the ROM firmware. */
> return;
> }
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-11-13 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 22:04 [PATCH] dma: imx-sdma: clarify about firmware not found error Fabio Estevam
2014-11-13 1:28 ` Shawn Guo [this message]
2014-11-17 7:54 ` Sascha Hauer
2014-11-19 17:29 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113012814.GO2704@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.