From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/2] mfd: dln2: add support for USB-SPI module Date: Thu, 13 Nov 2014 10:32:20 +0000 Message-ID: <20141113103220.GL24004@x1> References: <1415364314-30320-1-git-send-email-laurentiu.palcu@intel.com> <1415364314-30320-3-git-send-email-laurentiu.palcu@intel.com> <20141110093005.GF21424@x1> <20141111130904.GN5826@lpalcu-linux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Mark Brown , Samuel Ortiz , Johan Havold , Octavian Purdila , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurentiu Palcu Return-path: Content-Disposition: inline In-Reply-To: <20141111130904.GN5826@lpalcu-linux> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Tue, 11 Nov 2014, Laurentiu Palcu wrote: > Hi Lee, >=20 > On Mon, Nov 10, 2014 at 09:30:05AM +0000, Lee Jones wrote: > > On Fri, 07 Nov 2014, Laurentiu Palcu wrote: > >=20 > > > Signed-off-by: Laurentiu Palcu > > > --- > > > drivers/mfd/dln2.c | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > >=20 > > > diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c > > > index 9765a17..0cdad2d 100644 > > > --- a/drivers/mfd/dln2.c > > > +++ b/drivers/mfd/dln2.c > > > @@ -52,6 +52,7 @@ enum dln2_handle { > > > DLN2_HANDLE_CTRL, > > > DLN2_HANDLE_GPIO, > > > DLN2_HANDLE_I2C, > > > + DLN2_HANDLE_SPI, > > > DLN2_HANDLES > > > }; > > > =20 > > > @@ -634,6 +635,12 @@ static struct dln2_platform_data dln2_pdata_= i2c =3D { > > > .port =3D 0, > > > }; > > > =20 > > > +/* Only one SPI port supported */ > > > +static struct dln2_platform_data dln2_pdata_spi =3D { > >=20 > > Is this ever fiddled with? If not, const? > Well, if we declare this const we also need to cast the assignment be= low to > void* since platform_data is void*. Otherwise we get a "assignment > discards =E2=80=98const=E2=80=99 qualifier from pointer target type" = warning.=20 >=20 > Also, for consistency, we have to do it for all dln2_pdata_*. I'm not > sure it's worth it... Yes, perhaps you are right. Patch applied. > > > + .handle =3D DLN2_HANDLE_SPI, > > > + .port =3D 0, > > > +}; > > > + > > > static const struct mfd_cell dln2_devs[] =3D { > > > { > > > .name =3D "dln2-gpio", > > > @@ -645,6 +652,11 @@ static const struct mfd_cell dln2_devs[] =3D= { > > > .platform_data =3D &dln2_pdata_i2c, > > > .pdata_size =3D sizeof(struct dln2_platform_data), > > > }, > > > + { > > > + .name =3D "dln2-spi", > > > + .platform_data =3D &dln2_pdata_spi, > > > + .pdata_size =3D sizeof(struct dln2_platform_data), > > > + }, > > > }; > > > =20 > > > static void dln2_disconnect(struct usb_interface *interface) > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932534AbaKMKc3 (ORCPT ); Thu, 13 Nov 2014 05:32:29 -0500 Received: from mail-ie0-f171.google.com ([209.85.223.171]:39212 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932241AbaKMKc1 (ORCPT ); Thu, 13 Nov 2014 05:32:27 -0500 Date: Thu, 13 Nov 2014 10:32:20 +0000 From: Lee Jones To: Laurentiu Palcu Cc: Mark Brown , Samuel Ortiz , Johan Havold , Octavian Purdila , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: dln2: add support for USB-SPI module Message-ID: <20141113103220.GL24004@x1> References: <1415364314-30320-1-git-send-email-laurentiu.palcu@intel.com> <1415364314-30320-3-git-send-email-laurentiu.palcu@intel.com> <20141110093005.GF21424@x1> <20141111130904.GN5826@lpalcu-linux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141111130904.GN5826@lpalcu-linux> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Nov 2014, Laurentiu Palcu wrote: > Hi Lee, > > On Mon, Nov 10, 2014 at 09:30:05AM +0000, Lee Jones wrote: > > On Fri, 07 Nov 2014, Laurentiu Palcu wrote: > > > > > Signed-off-by: Laurentiu Palcu > > > --- > > > drivers/mfd/dln2.c | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c > > > index 9765a17..0cdad2d 100644 > > > --- a/drivers/mfd/dln2.c > > > +++ b/drivers/mfd/dln2.c > > > @@ -52,6 +52,7 @@ enum dln2_handle { > > > DLN2_HANDLE_CTRL, > > > DLN2_HANDLE_GPIO, > > > DLN2_HANDLE_I2C, > > > + DLN2_HANDLE_SPI, > > > DLN2_HANDLES > > > }; > > > > > > @@ -634,6 +635,12 @@ static struct dln2_platform_data dln2_pdata_i2c = { > > > .port = 0, > > > }; > > > > > > +/* Only one SPI port supported */ > > > +static struct dln2_platform_data dln2_pdata_spi = { > > > > Is this ever fiddled with? If not, const? > Well, if we declare this const we also need to cast the assignment below to > void* since platform_data is void*. Otherwise we get a "assignment > discards ‘const’ qualifier from pointer target type" warning. > > Also, for consistency, we have to do it for all dln2_pdata_*. I'm not > sure it's worth it... Yes, perhaps you are right. Patch applied. > > > + .handle = DLN2_HANDLE_SPI, > > > + .port = 0, > > > +}; > > > + > > > static const struct mfd_cell dln2_devs[] = { > > > { > > > .name = "dln2-gpio", > > > @@ -645,6 +652,11 @@ static const struct mfd_cell dln2_devs[] = { > > > .platform_data = &dln2_pdata_i2c, > > > .pdata_size = sizeof(struct dln2_platform_data), > > > }, > > > + { > > > + .name = "dln2-spi", > > > + .platform_data = &dln2_pdata_spi, > > > + .pdata_size = sizeof(struct dln2_platform_data), > > > + }, > > > }; > > > > > > static void dln2_disconnect(struct usb_interface *interface) > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog