From: Jens Stimpfle <debian@jstimpfle.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-send-email.perl: Fix handling of suppresscc option.
Date: Thu, 13 Nov 2014 12:41:04 +0100 [thread overview]
Message-ID: <20141113114104.GA27098@jstimpfle.de> (raw)
In-Reply-To: <xmqqoasc46ph.fsf@gitster.dls.corp.google.com>
Junio, thanks for reviewing.
On Wed, Nov 12, 2014 at 10:25:14AM -0800, Junio C Hamano wrote:
> "When I say addresses on Cc: does not matter, it doesn't. No matter
> what the address in question is" (likewise for S-o-b:) is what the
> updated logic says. It is easier to explain than the traditional
> "The way to squelch my address is by 'suppress self'; for all other
> addresses on Cc:/S-o-b:, there are separate suppression methods".
>
> But I have a slight suspicion that this special casing of 'self' was
> done on purpose, and people may be relying on it.
It seems the behaviour is exactly described in the manpage. Sorry for
having missed that.
The behaviour is super-complex and confusing, though. It's easy to
imagine much simpler, intuitive and "transparent" ones.
But I have no experience with distributed git workflows so I'm
absolutely not in the position to call it broken or provide a "fix".
Sorry for the noise.
prev parent reply other threads:[~2014-11-13 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 14:18 [PATCH] git-send-email.perl: Fix handling of suppresscc option Jens Stimpfle
2014-11-12 18:25 ` Junio C Hamano
2014-11-13 11:41 ` Jens Stimpfle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113114104.GA27098@jstimpfle.de \
--to=debian@jstimpfle.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.