From: Christoph Hellwig <hch@infradead.org>
To: Barto <mister.freeman@laposte.net>
Cc: Christoph Hellwig <hch@infradead.org>,
"Elliott, Robert (Server Storage)" <Elliott@hp.com>,
Guenter Roeck <linux@roeck-us.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: BUG in scsi_lib.c due to a bad commit
Date: Thu, 13 Nov 2014 09:54:02 -0800 [thread overview]
Message-ID: <20141113175402.GA27327@infradead.org> (raw)
In-Reply-To: <5464E6E6.3090606@laposte.net>
On Thu, Nov 13, 2014 at 06:14:14PM +0100, Barto wrote:
> Hello Christoph,
>
> I tested this commit :
>
> 7ae65c0f9646c29432b69580b80e08632e6cd813 scsi: convert target_busy to an
> atomic_t
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7ae65c0f9646c29432b69580b80e08632e6cd813
>
> there is no bug, boot process is ok whit this commit,
>
> when I did the "git bisect" the first bad commit was Guenters' commit (
> 045065d8a300a37218c548e9aa7becd581c6a0e8 ), it seems that all commits
> before 045065d8a300a37218c548e9aa7becd581c6a0e8 are ok,
The bisect isn't quite interesting here as we're trying to find the real
root ause.
045065d8a300a37218c548e9aa7becd581c6a0e8 reverts the polarity of the
check that 71e75c97f97a9645d25fbf3d8e4165a558f18747 incorrectly
chaged.
The behavior you see doesn't make a lot of sense from a high level view,
so we need to find out what's going on.
When you say all commits before 045065d8a300a37218c548e9aa7becd581c6a0e8
I wonder if the bisect simply skiped to many revisions.
Please explicitly test commits:
71e75c97f97a9645d25fbf3d8e4165a558f18747
and
74665016086615bbaa3fa6f83af410a0a4e029ee
Thanks!
next prev parent reply other threads:[~2014-11-13 17:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 23:33 BUG in scsi_lib.c due to a bad commit Barto
2014-11-12 0:17 ` Bjorn Helgaas
2014-11-12 2:53 ` Guenter Roeck
2014-11-13 3:28 ` Barto
2014-11-13 5:33 ` Elliott, Robert (Server Storage)
2014-11-13 5:33 ` Elliott, Robert (Server Storage)
2014-11-13 9:38 ` Barto
2014-11-13 14:29 ` Christoph Hellwig
2014-11-13 15:13 ` Barto
2014-11-13 17:14 ` Barto
2014-11-13 17:54 ` Christoph Hellwig [this message]
2014-11-13 22:55 ` Barto
2014-11-14 7:32 ` Christoph Hellwig
2014-11-14 16:30 ` Barto
2014-11-16 18:30 ` Barto
2014-11-19 20:21 ` Barto
-- strict thread matches above, loose matches on Subject: below --
2014-11-20 6:09 Christoph Hellwig
2014-11-20 17:44 ` Barto
2014-11-20 17:53 ` Christoph Hellwig
2014-11-20 18:27 ` Barto
2014-11-24 9:18 ` Christoph Hellwig
2014-11-24 15:12 ` Barto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113175402.GA27327@infradead.org \
--to=hch@infradead.org \
--cc=Elliott@hp.com \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mister.freeman@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.