From: Bjorn Helgaas <bhelgaas@google.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pci@vger.kernel.org,
'Thomas Petazzoni' <thomas.petazzoni@free-electrons.com>,
'Jason Cooper' <jason@lakedaemon.net>
Subject: Re: [PATCH] PCI: mvebu: Add a blank line after declarations
Date: Thu, 13 Nov 2014 10:55:21 -0700 [thread overview]
Message-ID: <20141113175521.GP5064@google.com> (raw)
In-Reply-To: <002b01cffe28$a57021d0$f0506570$%han@samsung.com>
On Wed, Nov 12, 2014 at 12:27:54PM +0900, Jingoo Han wrote:
> This patch fixes the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied with Jason's ack to pci/host-mvebu for v3.19, thanks!
I dropped the mvebu_pcie_add_bus() hunk because I have a patch in pci/msi
that removes that function altogether.
> ---
> drivers/pci/host/pci-mvebu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index b1315e1..0c775afa 100644
> --- a/drivers/pci/host/pci-mvebu.c
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -622,6 +622,7 @@ static struct mvebu_pcie_port *mvebu_pcie_find_port(struct mvebu_pcie *pcie,
>
> for (i = 0; i < pcie->nports; i++) {
> struct mvebu_pcie_port *port = &pcie->ports[i];
> +
> if (bus->number == 0 && port->devfn == devfn)
> return port;
> if (bus->number != 0 &&
> @@ -751,6 +752,7 @@ static int mvebu_pcie_setup(int nr, struct pci_sys_data *sys)
>
> for (i = 0; i < pcie->nports; i++) {
> struct mvebu_pcie_port *port = &pcie->ports[i];
> +
> if (!port->base)
> continue;
> mvebu_pcie_setup_hw(port);
> @@ -777,6 +779,7 @@ static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
> static void mvebu_pcie_add_bus(struct pci_bus *bus)
> {
> struct mvebu_pcie *pcie = sys_to_pcie(bus->sysdata);
> +
> bus->msi = pcie->msi;
> }
>
> --
> 1.7.9.5
>
>
prev parent reply other threads:[~2014-11-13 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 3:27 [PATCH] PCI: mvebu: Add a blank line after declarations Jingoo Han
2014-11-12 13:32 ` Jason Cooper
2014-11-13 17:55 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113175521.GP5064@google.com \
--to=bhelgaas@google.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.