From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: kan.liang@intel.com, acme@kernel.org, a.p.zijlstra@chello.nl,
eranian@google.com, linux-kernel@vger.kernel.org,
mingo@redhat.com, paulus@samba.org
Subject: Re: [PATCH V2 2/3] perf tool: re-organize thread__resolve_callchain_sample
Date: Thu, 13 Nov 2014 10:48:10 -0800 [thread overview]
Message-ID: <20141113184810.GC4358@tassilo.jf.intel.com> (raw)
In-Reply-To: <20141113182123.GA6309@krava.redhat.com>
> Any chance you guys could sync on this? ..you're touching the
> same code.. Andi, maybe you wouldn't mind having this patch
> instead of your change.. looks like the only extra part is the
> cpumode resolve.
Please just merge one of them, and the other can rebase.
Note the lbr as callgraph has been posted since nearly a year now
(v1 was in January)
If you merged patches faster all these problems with conflicts
wouldn't happen.
-Andi
next prev parent reply other threads:[~2014-11-13 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 0:18 [PATCH V2 0/3] perf tool: Haswell LBR call stack support (user) kan.liang
2014-11-13 0:18 ` [PATCH V2 1/3] perf tools: enable LBR call stack support kan.liang
2014-11-13 0:18 ` [PATCH V2 2/3] perf tool: re-organize thread__resolve_callchain_sample kan.liang
2014-11-13 18:21 ` Jiri Olsa
2014-11-13 18:48 ` Andi Kleen [this message]
2014-11-14 8:23 ` Jiri Olsa
2014-11-13 0:18 ` [PATCH V2 3/3] perf tools: Construct LBR call chain kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113184810.GC4358@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.