All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Cristian Stoica" <cristian.stoica@freescale.com>,
	"Horia Geanta" <horia.geanta@freescale.com>,
	"Ruchika Gupta" <ruchika.gupta@freescale.com>,
	"Michael Neuling" <mikey@neuling.org>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Vinod Koul" <vinod.koul@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Dave Jiang" <dave.jiang@intel.com>,
	Rashika <rashika.kheria@gmail.com>,
	"open list:DMA GENERIC OFFLO..." <dmaengine@vger.kernel.org>
Subject: Re: [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence()
Date: Thu, 13 Nov 2014 12:07:01 -0800	[thread overview]
Message-ID: <20141113200701.GP4460@linux.vnet.ibm.com> (raw)
In-Reply-To: <1415906662-4576-1-git-send-email-bobby.prani@gmail.com>

On Thu, Nov 13, 2014 at 02:24:06PM -0500, Pranith Kumar wrote:
> Recently lockless_dereference() was added which can be used in place of
> hard-coding smp_read_barrier_depends(). 
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1410.3/04561.html
> 
> The following series tries to do this.
> 
> There are still some hard-coded locations which I was not sure how to replace
> with. I will send in separate patches/questions regarding them.

Thank you for taking this on!  Some questions and comments in response
to the individual patches.

							Thanx, Paul

> Pranith Kumar (16):
>   crypto: caam - Remove unnecessary smp_read_barrier_depends()
>   doc: memory-barriers.txt: Document use of lockless_dereference()
>   drivers: dma: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   dcache: Replace smp_read_barrier_depends() with lockless_dereference()
>   overlayfs: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   assoc_array: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   hyperv: Replace smp_read_barrier_depends() with lockless_dereference()
>   rcupdate: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   percpu: Replace smp_read_barrier_depends() with lockless_dereference()
>   perf: Replace smp_read_barrier_depends() with lockless_dereference()
>   seccomp: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   task_work: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   ksm: Replace smp_read_barrier_depends() with lockless_dereference()
>   slab: Replace smp_read_barrier_depends() with lockless_dereference()
>   netfilter: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   rxrpc: Replace smp_read_barrier_depends() with lockless_dereference()
> 
>  Documentation/memory-barriers.txt |  2 +-
>  drivers/crypto/caam/jr.c          |  3 ---
>  drivers/dma/ioat/dma_v2.c         |  3 +--
>  drivers/dma/ioat/dma_v3.c         |  3 +--
>  fs/dcache.c                       |  7 ++-----
>  fs/overlayfs/super.c              |  4 +---
>  include/linux/assoc_array_priv.h  | 11 +++++++----
>  include/linux/hyperv.h            |  9 ++++-----
>  include/linux/percpu-refcount.h   |  4 +---
>  include/linux/rcupdate.h          | 10 +++++-----
>  kernel/events/core.c              |  3 +--
>  kernel/events/uprobes.c           |  8 ++++----
>  kernel/seccomp.c                  |  7 +++----
>  kernel/task_work.c                |  3 +--
>  lib/assoc_array.c                 |  7 -------
>  mm/ksm.c                          |  7 +++----
>  mm/slab.h                         |  6 +++---
>  net/ipv4/netfilter/arp_tables.c   |  3 +--
>  net/ipv4/netfilter/ip_tables.c    |  3 +--
>  net/ipv6/netfilter/ip6_tables.c   |  3 +--
>  net/rxrpc/ar-ack.c                | 22 +++++++++-------------
>  security/keys/keyring.c           |  6 ------
>  22 files changed, 50 insertions(+), 84 deletions(-)
> 
> -- 
> 1.9.1
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Cristian Stoica" <cristian.stoica@freescale.com>,
	"Horia Geanta" <horia.geanta@freescale.com>,
	"Ruchika Gupta" <ruchika.gupta@freescale.com>,
	"Michael Neuling" <mikey@neuling.org>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Vinod Koul" <vinod.koul@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Dave Jiang" <dave.jiang@intel.com>,
	Rashika <rashika.kheria@gmail.com>,
	"open list:DMA GENERIC OFFLO..." <dmaengine@vger.kernel.org>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"open list:Hyper-V CORE AND..." <devel@linuxdriverproject.org>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Lai Jiangshan" <laijs@cn.fujitsu.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Christoph Lameter" <cl@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Kees Cook" <keescook@chromium.org>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Will Drewry" <wad@chromium.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	"Hugh Dickins" <hughd@google.com>, NeilBrown <neilb@suse.de>,
	"Joerg Roedel" <jroedel@suse.de>,
	"Sasha Levin" <sasha.levin@oracle.com>,
	"Paul McQuade" <paulmcquad@gmail.com>,
	"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	"open list:NETWORKING [IPv4/..." <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence()
Date: Thu, 13 Nov 2014 12:07:01 -0800	[thread overview]
Message-ID: <20141113200701.GP4460@linux.vnet.ibm.com> (raw)
In-Reply-To: <1415906662-4576-1-git-send-email-bobby.prani@gmail.com>

On Thu, Nov 13, 2014 at 02:24:06PM -0500, Pranith Kumar wrote:
> Recently lockless_dereference() was added which can be used in place of
> hard-coding smp_read_barrier_depends(). 
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1410.3/04561.html
> 
> The following series tries to do this.
> 
> There are still some hard-coded locations which I was not sure how to replace
> with. I will send in separate patches/questions regarding them.

Thank you for taking this on!  Some questions and comments in response
to the individual patches.

							Thanx, Paul

> Pranith Kumar (16):
>   crypto: caam - Remove unnecessary smp_read_barrier_depends()
>   doc: memory-barriers.txt: Document use of lockless_dereference()
>   drivers: dma: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   dcache: Replace smp_read_barrier_depends() with lockless_dereference()
>   overlayfs: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   assoc_array: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   hyperv: Replace smp_read_barrier_depends() with lockless_dereference()
>   rcupdate: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   percpu: Replace smp_read_barrier_depends() with lockless_dereference()
>   perf: Replace smp_read_barrier_depends() with lockless_dereference()
>   seccomp: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   task_work: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   ksm: Replace smp_read_barrier_depends() with lockless_dereference()
>   slab: Replace smp_read_barrier_depends() with lockless_dereference()
>   netfilter: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   rxrpc: Replace smp_read_barrier_depends() with lockless_dereference()
> 
>  Documentation/memory-barriers.txt |  2 +-
>  drivers/crypto/caam/jr.c          |  3 ---
>  drivers/dma/ioat/dma_v2.c         |  3 +--
>  drivers/dma/ioat/dma_v3.c         |  3 +--
>  fs/dcache.c                       |  7 ++-----
>  fs/overlayfs/super.c              |  4 +---
>  include/linux/assoc_array_priv.h  | 11 +++++++----
>  include/linux/hyperv.h            |  9 ++++-----
>  include/linux/percpu-refcount.h   |  4 +---
>  include/linux/rcupdate.h          | 10 +++++-----
>  kernel/events/core.c              |  3 +--
>  kernel/events/uprobes.c           |  8 ++++----
>  kernel/seccomp.c                  |  7 +++----
>  kernel/task_work.c                |  3 +--
>  lib/assoc_array.c                 |  7 -------
>  mm/ksm.c                          |  7 +++----
>  mm/slab.h                         |  6 +++---
>  net/ipv4/netfilter/arp_tables.c   |  3 +--
>  net/ipv4/netfilter/ip_tables.c    |  3 +--
>  net/ipv6/netfilter/ip6_tables.c   |  3 +--
>  net/rxrpc/ar-ack.c                | 22 +++++++++-------------
>  security/keys/keyring.c           |  6 ------
>  22 files changed, 50 insertions(+), 84 deletions(-)
> 
> -- 
> 1.9.1
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Cristian Stoica" <cristian.stoica@freescale.com>,
	"Horia Geanta" <horia.geanta@freescale.com>,
	"Ruchika Gupta" <ruchika.gupta@freescale.com>,
	"Michael Neuling" <mikey@neuling.org>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Vinod Koul" <vinod.koul@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Dave Jiang" <dave.jiang@intel.com>,
	Rashika <rashika.kheria@gmail.com>,
	"open list:DMA GENERIC OFFLO..." <dmaengine@vger.kernel.org>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"open list:Hyper-V CORE AND..." <devel@linuxdriverproject.org>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Lai Jiangshan" <laijs@cn.fujitsu.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Christoph Lameter" <cl@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Kees Cook" <keescook@chromium.org>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Will Drewry" <wad@chromium.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	"Hugh Dickins" <hughd@google.com>, NeilBrown <neilb@suse.de>,
	"Joerg Roedel" <jroedel@suse.de>,
	"Sasha Levin" <sasha.levin@oracle.com>,
	"Paul McQuade" <paulmcquad@gmail.com>,
	"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	"open list:NETWORKING [IPv4/..." <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence()
Date: Thu, 13 Nov 2014 12:07:01 -0800	[thread overview]
Message-ID: <20141113200701.GP4460@linux.vnet.ibm.com> (raw)
In-Reply-To: <1415906662-4576-1-git-send-email-bobby.prani@gmail.com>

On Thu, Nov 13, 2014 at 02:24:06PM -0500, Pranith Kumar wrote:
> Recently lockless_dereference() was added which can be used in place of
> hard-coding smp_read_barrier_depends(). 
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1410.3/04561.html
> 
> The following series tries to do this.
> 
> There are still some hard-coded locations which I was not sure how to replace
> with. I will send in separate patches/questions regarding them.

Thank you for taking this on!  Some questions and comments in response
to the individual patches.

							Thanx, Paul

> Pranith Kumar (16):
>   crypto: caam - Remove unnecessary smp_read_barrier_depends()
>   doc: memory-barriers.txt: Document use of lockless_dereference()
>   drivers: dma: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   dcache: Replace smp_read_barrier_depends() with lockless_dereference()
>   overlayfs: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   assoc_array: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   hyperv: Replace smp_read_barrier_depends() with lockless_dereference()
>   rcupdate: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   percpu: Replace smp_read_barrier_depends() with lockless_dereference()
>   perf: Replace smp_read_barrier_depends() with lockless_dereference()
>   seccomp: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   task_work: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   ksm: Replace smp_read_barrier_depends() with lockless_dereference()
>   slab: Replace smp_read_barrier_depends() with lockless_dereference()
>   netfilter: Replace smp_read_barrier_depends() with
>     lockless_dereference()
>   rxrpc: Replace smp_read_barrier_depends() with lockless_dereference()
> 
>  Documentation/memory-barriers.txt |  2 +-
>  drivers/crypto/caam/jr.c          |  3 ---
>  drivers/dma/ioat/dma_v2.c         |  3 +--
>  drivers/dma/ioat/dma_v3.c         |  3 +--
>  fs/dcache.c                       |  7 ++-----
>  fs/overlayfs/super.c              |  4 +---
>  include/linux/assoc_array_priv.h  | 11 +++++++----
>  include/linux/hyperv.h            |  9 ++++-----
>  include/linux/percpu-refcount.h   |  4 +---
>  include/linux/rcupdate.h          | 10 +++++-----
>  kernel/events/core.c              |  3 +--
>  kernel/events/uprobes.c           |  8 ++++----
>  kernel/seccomp.c                  |  7 +++----
>  kernel/task_work.c                |  3 +--
>  lib/assoc_array.c                 |  7 -------
>  mm/ksm.c                          |  7 +++----
>  mm/slab.h                         |  6 +++---
>  net/ipv4/netfilter/arp_tables.c   |  3 +--
>  net/ipv4/netfilter/ip_tables.c    |  3 +--
>  net/ipv6/netfilter/ip6_tables.c   |  3 +--
>  net/rxrpc/ar-ack.c                | 22 +++++++++-------------
>  security/keys/keyring.c           |  6 ------
>  22 files changed, 50 insertions(+), 84 deletions(-)
> 
> -- 
> 1.9.1
> 


  parent reply	other threads:[~2014-11-13 20:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 19:24 [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Pranith Kumar
2014-11-13 19:24 ` Pranith Kumar
2014-11-13 19:24 ` Pranith Kumar
2014-11-13 19:24 ` [PATCH 01/16] crypto: caam - Remove unnecessary smp_read_barrier_depends() Pranith Kumar
2014-11-13 20:10   ` Paul E. McKenney
     [not found]     ` <546527D0.9040806@gmail.com>
2014-11-14  0:58       ` Kim Phillips
2014-11-13 19:24 ` [PATCH 02/16] doc: memory-barriers.txt: Document use of lockless_dereference() Pranith Kumar
2014-11-13 20:11   ` Paul E. McKenney
2014-11-13 19:24 ` [PATCH 03/16] drivers: dma: Replace smp_read_barrier_depends() with lockless_dereference() Pranith Kumar
2014-11-13 19:24 ` [PATCH 04/16] dcache: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 05/16] overlayfs: " Pranith Kumar
2014-11-17 10:35   ` Miklos Szeredi
2014-11-13 19:24 ` [PATCH 06/16] assoc_array: " Pranith Kumar
2014-11-13 20:11   ` David Howells
2014-11-13 19:24 ` [PATCH 07/16] hyperv: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 08/16] rcupdate: " Pranith Kumar
2014-11-18 17:16   ` Paul E. McKenney
2014-11-18 19:38     ` Pranith Kumar
2014-11-13 19:24 ` [PATCH 09/16] percpu: " Pranith Kumar
2014-11-14 13:14   ` Tejun Heo
2014-11-14 16:02     ` Pranith Kumar
2014-11-17  4:43     ` Paul E. McKenney
2014-11-13 19:24 ` [PATCH 10/16] perf: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 11/16] seccomp: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 12/16] task_work: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 13/16] ksm: " Pranith Kumar
2014-11-13 19:24   ` Pranith Kumar
2014-11-30 22:34   ` Hugh Dickins
2014-11-30 22:34     ` Hugh Dickins
2014-11-13 19:24 ` [PATCH 14/16] slab: " Pranith Kumar
2014-11-13 19:24   ` Pranith Kumar
2014-11-13 19:24 ` [PATCH 15/16] netfilter: " Pranith Kumar
2014-11-13 19:24 ` [PATCH 16/16] rxrpc: " Pranith Kumar
2014-11-13 20:17   ` David Howells
2014-11-13 20:47   ` David Howells
2014-11-13 21:55     ` Pranith Kumar
2014-11-13 23:07       ` David Howells
2014-11-13 20:07 ` Paul E. McKenney [this message]
2014-11-13 20:07   ` [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Paul E. McKenney
2014-11-13 20:07   ` Paul E. McKenney
  -- strict thread matches above, loose matches on Subject: below --
2014-11-13 19:24 Pranith Kumar
2014-11-13 19:24 Pranith Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141113200701.GP4460@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=bobby.prani@gmail.com \
    --cc=cristian.stoica@freescale.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@freescale.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.schoelling@gmx.de \
    --cc=mikey@neuling.org \
    --cc=rashika.kheria@gmail.com \
    --cc=ruchika.gupta@freescale.com \
    --cc=vinod.koul@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.