All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>, Petr Mladek <pmladek@suse.cz>
Subject: [RFC][PATCH 19/23 v4] seq_buf: Create seq_buf_used() to find out how much was written
Date: Thu, 13 Nov 2014 20:13:03 -0500	[thread overview]
Message-ID: <20141114011413.321654244@goodmis.org> (raw)
In-Reply-To: 20141114011244.256115061@goodmis.org

[-- Attachment #1: 0019-seq_buf-Create-seq_buf_used-to-find-out-how-much-was.patch --]
[-- Type: text/plain, Size: 1553 bytes --]

From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

Add a helper function seq_buf_used() that replaces the SEQ_BUF_USED()
private macro to let callers have a method to know how much of the
seq_buf was written to.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/linux/seq_buf.h | 6 ++++++
 kernel/trace/seq_buf.c  | 5 +----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h
index 3e550d214187..8fda502ee630 100644
--- a/include/linux/seq_buf.h
+++ b/include/linux/seq_buf.h
@@ -64,6 +64,12 @@ seq_buf_buffer_left(struct seq_buf *s)
 	return s->size - s->len;
 }
 
+/* How much buffer was written? */
+static inline unsigned int seq_buf_used(struct seq_buf *s)
+{
+	return min((s)->len, (s)->size);
+}
+
 /**
  * seq_buf_get_buf - get buffer to write arbitrary data to
  * @s: the seq_buf handle
diff --git a/kernel/trace/seq_buf.c b/kernel/trace/seq_buf.c
index 4f35a783b82f..3657af4b5f53 100644
--- a/kernel/trace/seq_buf.c
+++ b/kernel/trace/seq_buf.c
@@ -16,9 +16,6 @@
 #include <linux/seq_file.h>
 #include <linux/seq_buf.h>
 
-/* How much buffer is written? */
-#define SEQ_BUF_USED(s) min((s)->len, (s)->size)
-
 /**
  * seq_buf_print_seq - move the contents of seq_buf into a seq_file
  * @m: the seq_file descriptor that is the destination
@@ -28,7 +25,7 @@
  */
 int seq_buf_print_seq(struct seq_file *m, struct seq_buf *s)
 {
-	unsigned int len = SEQ_BUF_USED(s);
+	unsigned int len = seq_buf_used(s);
 
 	return seq_write(m, s->buffer, len);
 }
-- 
2.1.1



  parent reply	other threads:[~2014-11-14  1:15 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  1:12 [RFC][PATCH 00/23 v4] trace-seq/seq-buf/x86/printk: Print all stacks from NMI safely Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 01/23 v4] tracing: Fix trace_seq_bitmask() to start at current position Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return() Steven Rostedt
2014-11-14 11:25   ` Petr Mladek
2014-11-14 11:58     ` Steven Rostedt
2014-11-14 18:21     ` Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 03/23 v4] blktrace/tracing: Use trace_seq_has_overflowed() helper function Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 04/23 v4] ring-buffer: Remove check of trace_seq_{puts,printf}() return values Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 05/23 v4] tracing: Have branch tracer use trace_handle_return() helper function Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 06/23 v4] tracing: Have function_graph use trace_seq_has_overflowed() Steven Rostedt
2014-11-14 12:41   ` Petr Mladek
2014-11-14 12:52     ` Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 07/23 v4] kprobes/tracing: Use trace_seq_has_overflowed() for overflow checks Steven Rostedt
2014-11-14  5:24   ` Srikar Dronamraju
2014-11-14 14:51   ` Masami Hiramatsu
2014-11-14  1:12 ` [RFC][PATCH 08/23 v4] tracing: Do not check return values of trace_seq_p*() for mmio tracer Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 09/23 v4] tracing/probes: Do not use return value of trace_seq_printf() Steven Rostedt
2014-11-14 15:30   ` Masami Hiramatsu
2014-11-18  0:30   ` Namhyung Kim
2014-11-14  1:12 ` [RFC][PATCH 10/23 v4] tracing/uprobes: Do not use return values " Steven Rostedt
2014-11-14  5:23   ` Srikar Dronamraju
2014-11-14 15:35   ` Masami Hiramatsu
2014-11-14 15:37     ` Steven Rostedt
2014-11-14 18:14       ` Steven Rostedt
2014-11-18  0:32         ` Namhyung Kim
2014-11-14  1:12 ` [RFC][PATCH 11/23 v4] tracing: Do not use return values of trace_seq_printf() in syscall tracing Steven Rostedt
2014-11-18  0:49   ` Namhyung Kim
2014-11-18  2:44     ` Steven Rostedt
2014-11-18  3:04       ` Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions Steven Rostedt
2014-11-14 13:17   ` Petr Mladek
2014-11-14 14:53     ` Steven Rostedt
2014-11-14 16:21       ` Steven Rostedt
2014-11-14 17:09     ` Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 13/23 v4] tracing: Create seq_buf layer in trace_seq Steven Rostedt
2014-11-14 16:26   ` Petr Mladek
2014-11-14 17:19     ` Steven Rostedt
2014-11-14 17:23     ` Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 14/23 v4] tracing: Convert seq_buf_path() to be like seq_path() Steven Rostedt
2014-11-14 16:53   ` Petr Mladek
2014-11-14 17:47     ` Steven Rostedt
2014-11-14  1:12 ` [RFC][PATCH 15/23 v4] tracing: Convert seq_buf fields to be like seq_file fields Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 16/23 v4] tracing: Add a seq_buf_clear() helper and clear len and readpos in init Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 17/23 v4] tracing: Have seq_buf use full buffer Steven Rostedt
2014-11-14 17:07   ` Petr Mladek
2014-11-14 17:30     ` Steven Rostedt
2014-11-14 20:56       ` Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 18/23 v4] tracing: Add seq_buf_get_buf() and seq_buf_commit() helper functions Steven Rostedt
2014-11-14 17:18   ` Petr Mladek
2014-11-14 20:31     ` Steven Rostedt
2014-11-14 20:58       ` Steven Rostedt
2014-11-14  1:13 ` Steven Rostedt [this message]
2014-11-14 17:23   ` [RFC][PATCH 19/23 v4] seq_buf: Create seq_buf_used() to find out how much was written Petr Mladek
2014-11-14 17:34     ` Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 20/23 v4] seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTF Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 21/23 v4] seq_buf: Move the seq_buf code to lib/ Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 22/23 v4] printk: Add per_cpu printk func to allow printk to be diverted Steven Rostedt
2014-11-14  1:13 ` [RFC][PATCH 23/23 v4] x86/nmi: Perform a safe NMI stack trace on all CPUs Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141114011413.321654244@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pmladek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.