Re: [PATCH 0/3] USB: host: Misc patches to remove hard-coded octeon platform information

[Andreas Herrmann <herrmann.der.user@googlemail.com>]

On Thu, Nov 13, 2014 at 05:13:36PM -0500, Alan Stern wrote:
> On Thu, 13 Nov 2014, Andreas Herrmann wrote:
> 
> > Hi Alan,
> > 
> > With following patches I want to base octeon ehci/ohci device
> > configuration on device tree information.
> > 
> > I picked up patches that were submitted in May. See
> > http://marc.info/?l=linux-usb&m=140135823325811&w=2
> > and http://marc.info/?l=linux-mips&m=140139694721623&w=2
> > 
> > Patch #1 is your "untested preliminary pass" to remove
> >  [oe]hci-octeon drivers.
> > Patch #2 is the removal of hard-coded platform information (but now
> >  rebased on your patch)
> > Patch #3 adapts dma_mask for ehci (as used in ehci-octeon)
> > 
> > Overall diffstat is
> > 
> >  arch/mips/cavium-octeon/octeon-platform.c |  380 +++++++++++++++++++++++------
> >  arch/mips/configs/cavium_octeon_defconfig |    3 +
> >  drivers/usb/host/Kconfig                  |   18 +-
> >  drivers/usb/host/Makefile                 |    1 -
> >  drivers/usb/host/ehci-hcd.c               |    5 -
> >  drivers/usb/host/ehci-octeon.c            |  188 --------------
> >  drivers/usb/host/ehci-platform.c          |    4 +-
> >  drivers/usb/host/octeon2-common.c         |  200 ---------------
> >  drivers/usb/host/ohci-hcd.c               |    5 -
> >  drivers/usb/host/ohci-octeon.c            |  202 ---------------
> >  drivers/usb/host/ohci-platform.c          |    1 +
> >  include/linux/usb/ehci_pdriver.h          |    1 +
> >  12 files changed, 330 insertions(+), 678 deletions(-)
> > 
> > Patches are based on v3.18-rc4-65-g2c54396
> > 
> > Comments welcome.
> 
> At a very quick first glance, it looks great.  Have you tested it 
> thoroughly?

 [sorry have to use another mail account, so far your mail didn't show
  up at my caviumnetworks account]

I've tested it only on an EdgeRouterPro (Octeon II system, which I
have on-site).

octeon_ehci_device_init and octeon_ohci_device_init run way before
ehci-platform and ohci-platform probe for devices. So everything
should be initialized orderly.

With current mainline (w/o these patches) USB doesn't work on my
EdgeRouterPro due to an (inappropriate) OCTEON_IS_MODEL check.

I'd say having the patches in linux-next for awhile wouldn't hurt.


Andreas