Re: [PATCH for-4.5 v2 0/4] libxl: CODING_STYLE

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Fri, Nov 14, 2014 at 06:52:37PM +0000, Ian Jackson wrote:
> The structural considerations, error handling patterns, and so on, in
> libxl have remained undocumented.  This has been a problem during
> recent code submissions and reviews.
> 
> In this series I have attempted to document current best practice.
> The first patch contains much new material and the others are minor
> and consequential fixes.
> 
> *1/4 libxl: CODING_STYLE: Much new material
>  2/4 libxl: CODING_STYLE: Deprecate `error' for out blocks
>  3/4 libxl: CODING_STYLE: Mention function out parameters
> *4/4 libxl: CODING_STYLE: Discuss existing style problems
> 
>  * = Modified patches, to take into account review comments from
>      Ian Campbell.
> 
> I would like to suggest that this ought to go into 4.5 because:
>  - it would be useful documentation to assist with any nontrivial
>    bugfixes that need to be made to libxl
>  - there isn't any risk of it actually breaking anything, because
>    it's just doc changes.

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Thanks,
> Ian.