From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH for-4.5 v2 0/4] libxl: CODING_STYLE Date: Fri, 14 Nov 2014 13:56:56 -0500 Message-ID: <20141114185656.GB20066@laptop.dumpdata.com> References: <1415991161-11293-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1415991161-11293-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Wei Liu , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Fri, Nov 14, 2014 at 06:52:37PM +0000, Ian Jackson wrote: > The structural considerations, error handling patterns, and so on, in > libxl have remained undocumented. This has been a problem during > recent code submissions and reviews. > > In this series I have attempted to document current best practice. > The first patch contains much new material and the others are minor > and consequential fixes. > > *1/4 libxl: CODING_STYLE: Much new material > 2/4 libxl: CODING_STYLE: Deprecate `error' for out blocks > 3/4 libxl: CODING_STYLE: Mention function out parameters > *4/4 libxl: CODING_STYLE: Discuss existing style problems > > * = Modified patches, to take into account review comments from > Ian Campbell. > > I would like to suggest that this ought to go into 4.5 because: > - it would be useful documentation to assist with any nontrivial > bugfixes that need to be made to libxl > - there isn't any risk of it actually breaking anything, because > it's just doc changes. Release-Acked-by: Konrad Rzeszutek Wilk > > Thanks, > Ian.