From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: fix ordering in Armada 370 .dtsi
Date: Fri, 14 Nov 2014 21:22:00 +0100 [thread overview]
Message-ID: <20141114202200.GI2001@lunn.ch> (raw)
In-Reply-To: <1415993776-3469-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Nov 14, 2014 at 08:36:16PM +0100, Uwe Kleine-K?nig wrote:
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
It is normal to have something in the changelog, even if it is the
same as the subject said differently.
Here you could say something like:
Commit a095b1c78a35f05755 "ARM: mvebu: sort DT nodes by address"
missed placing the system-controller in the correct order.
> ---
> arch/arm/boot/dts/armada-370.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index 6b3c23b1e138..7513410f7b89 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -106,11 +106,6 @@
> reg = <0x11100 0x20>;
> };
>
> - system-controller at 18200 {
> - compatible = "marvell,armada-370-xp-system-controller";
> - reg = <0x18200 0x100>;
> - };
> -
> pinctrl {
> compatible = "marvell,mv88f6710-pinctrl";
> reg = <0x18000 0x38>;
> @@ -205,6 +200,11 @@
> interrupts = <91>;
> };
>
> + system-controller at 18200 {
> + compatible = "marvell,armada-370-xp-system-controller";
> + reg = <0x18200 0x100>;
> + };
> +
> gateclk: clock-gating-control at 18220 {
> compatible = "marvell,armada-370-gating-clock";
> reg = <0x18220 0x4>;
Humm.
Now we have things in the right order, we see that the
system-controller and the clock-gating-controller overlap.
I know the HW engineers have gone a bit crazy around here, so maybe we
have no choice?
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH] ARM: mvebu: fix ordering in Armada 370 .dtsi
Date: Fri, 14 Nov 2014 21:22:00 +0100 [thread overview]
Message-ID: <20141114202200.GI2001@lunn.ch> (raw)
In-Reply-To: <1415993776-3469-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Fri, Nov 14, 2014 at 08:36:16PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
It is normal to have something in the changelog, even if it is the
same as the subject said differently.
Here you could say something like:
Commit a095b1c78a35f05755 "ARM: mvebu: sort DT nodes by address"
missed placing the system-controller in the correct order.
> ---
> arch/arm/boot/dts/armada-370.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index 6b3c23b1e138..7513410f7b89 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -106,11 +106,6 @@
> reg = <0x11100 0x20>;
> };
>
> - system-controller@18200 {
> - compatible = "marvell,armada-370-xp-system-controller";
> - reg = <0x18200 0x100>;
> - };
> -
> pinctrl {
> compatible = "marvell,mv88f6710-pinctrl";
> reg = <0x18000 0x38>;
> @@ -205,6 +200,11 @@
> interrupts = <91>;
> };
>
> + system-controller@18200 {
> + compatible = "marvell,armada-370-xp-system-controller";
> + reg = <0x18200 0x100>;
> + };
> +
> gateclk: clock-gating-control@18220 {
> compatible = "marvell,armada-370-gating-clock";
> reg = <0x18220 0x4>;
Humm.
Now we have things in the right order, we see that the
system-controller and the clock-gating-controller overlap.
I know the HW engineers have gone a bit crazy around here, so maybe we
have no choice?
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-14 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 19:36 [PATCH] ARM: mvebu: fix ordering in Armada 370 .dtsi Uwe Kleine-König
2014-11-14 19:36 ` Uwe Kleine-König
2014-11-14 20:22 ` Andrew Lunn [this message]
2014-11-14 20:22 ` Andrew Lunn
2014-11-17 9:49 ` Thomas Petazzoni
2014-11-17 9:49 ` Thomas Petazzoni
2014-11-14 20:43 ` [PATCH v2] " Uwe Kleine-König
2014-11-14 20:43 ` Uwe Kleine-König
2014-11-14 20:50 ` Andrew Lunn
2014-11-14 20:50 ` Andrew Lunn
2014-11-22 3:37 ` Jason Cooper
2014-11-22 3:37 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114202200.GI2001@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.