From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Date: Fri, 14 Nov 2014 13:32:56 -0800 Message-ID: <20141114213256.GA24709@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ig0-f177.google.com ([209.85.213.177]:49925 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335AbaKNVdA (ORCPT ); Fri, 14 Nov 2014 16:33:00 -0500 Received: by mail-ig0-f177.google.com with SMTP id uq10so1004016igb.16 for ; Fri, 14 Nov 2014 13:32:59 -0800 (PST) Content-Disposition: inline Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Alexandre Courbot , Wolfram Sang , James Hogan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual inspection of the code. drivers/gpio/gpio-tz1090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c index 9e90177..e3024bb 100644 --- a/drivers/gpio/gpio-tz1090.c +++ b/drivers/gpio/gpio-tz1090.c @@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info) bank->irq = irq_of_parse_and_map(np, 0); /* The interrupt is optional (it may be used by another core on chip) */ - if (bank->irq < 0) { + if (!bank->irq) { dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n", info->index); return 0; -- 2.1.0.rc2.206.gedb03e5 -- Dmitry