From: Karl Beldan <karl.beldan@gmail.com>
To: Jouni Malinen <j@w1.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Karl Beldan <karl.beldan@rivierawaves.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz
Date: Fri, 14 Nov 2014 23:40:18 +0100 [thread overview]
Message-ID: <20141114224018.GB14439@gobelin> (raw)
In-Reply-To: <20141114173648.GA31675@w1.fi>
On Fri, Nov 14, 2014 at 07:36:48PM +0200, Jouni Malinen wrote:
> On Fri, Nov 14, 2014 at 06:18:32PM +0100, Karl Beldan wrote:
> > Yes, only with iw and nothing fancy, I also have had it running on some
> > boards for some weeks as is and with rfc version for more than a year at
> > work (minstrel not the whole tree).
> > I guess I can take the tip of wireless-testing but can you give your
> > HEAD though ?
>
> It looks like pretty much any snapshot between master-2014-11-04 and now
> is affected.. Anyway, the current master snapshot in my tests was
> 0e204e2422876c18034ca960c4fccf727a02a5c1.
>
I tried to trigger the warning with it and nfc_p2p_* (even looping with
stop.sh; start.sh; run-tests.py nfc_p2p_*), to no avail, the tests are
successful and 0 warning.
I'll see if anything stands out in the code tomorrow.
Karl
> > > For example, with nfc_p2p_go_neg test case:
> >
> > Have you reproduced it with other testcases (maybe more regular so that
> > I can get my hands on it faster) ?
> > Is it also happening when VHT support is not advertized by upper layers
> > ?
>
> This seems to be specific to exact timing of frames since the same issue
> does not show up in non-NFC P2P test cases. So no, this does not show up
> with anything else than the nfc_p2p_* test cases (well, at least not in
> my desktop+kvm setup; YMMV with other CPU speeds that could potentially
> affect timing):
> nfc_p2p_go_neg
> nfc_p2p_go_neg_reverse
> nfc_p2p_ip_addr_assignment
> nfc_p2p_static_handover_tagdev_client
> nfc_p2p_static_handover_tagdev_client_group_iface
> nfc_p2p_static_handover_tagdev_go
>
> I'd assume the key here is in P2P with NFC trigger having the fastest
> possible connection process due to all the optimizations in channel
> selection on WPS (which is those EAPOL Data frames that hit these rate
> selection issues immediately after association).
>
> That said, if you use the tests/hwsim scripts from
> git://w1.fi/hostap.git there should be no difference on running some of
> these cases vs. something more regular..
>
> If you have not used these test scripts previously, you can find more
> information about the setup here:
> http://w1.fi/cgit/hostap/plain/tests/hwsim/README
> http://w1.fi/cgit/hostap/plain/tests/hwsim/vm/README
>
> --
> Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2014-11-14 22:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 13:45 [PATCH v5 0/4] add VHT support to minstrel_ht Karl Beldan
2014-10-20 13:45 ` [PATCH v5 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes Karl Beldan
2014-10-20 13:46 ` [PATCH v5 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs Karl Beldan
2014-10-20 13:46 ` [PATCH v5 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag Karl Beldan
2014-10-20 13:46 ` [PATCH v5 4/4] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Karl Beldan
2014-10-21 8:38 ` [PATCH v6] " Karl Beldan
2014-10-24 11:48 ` Karl Beldan
2014-10-24 12:01 ` Johannes Berg
2014-10-24 12:34 ` [PATCH] mac80211: minstrel_ht: do not always skip ht rates vht_only is true Karl Beldan
2014-10-24 12:40 ` Karl Beldan
2014-10-24 14:30 ` Johannes Berg
2014-10-24 14:33 ` Karl Beldan
2014-11-14 16:43 ` [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Jouni Malinen
2014-11-14 17:18 ` Karl Beldan
2014-11-14 17:36 ` Jouni Malinen
2014-11-14 18:29 ` Karl Beldan
2014-11-14 22:40 ` Karl Beldan [this message]
2014-10-20 14:49 ` [PATCH v5 0/4] add VHT support to minstrel_ht Johannes Berg
2014-10-20 15:13 ` Karl Beldan
2014-10-20 15:34 ` Karl Beldan
2014-10-20 19:33 ` Johannes Berg
2014-10-20 19:40 ` Johannes Berg
2014-10-21 8:41 ` Karl Beldan
2014-10-21 15:26 ` Karl Beldan
2014-10-21 18:47 ` Johannes Berg
2014-10-22 13:54 ` Karl Beldan
2014-10-22 14:07 ` Johannes Berg
2014-10-22 14:15 ` Karl Beldan
2014-10-22 14:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114224018.GB14439@gobelin \
--to=karl.beldan@gmail.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.